Re: [Xen-devel] [PATCH v4 06/34] x86/arm: Add BUGFRAME_NR define and BUILD checks.

2016-03-22 Thread Jan Beulich
>>> On 22.03.16 at 16:39, wrote: > On Mon, Mar 21, 2016 at 06:49:03AM -0600, Jan Beulich wrote: >> >>> On 18.03.16 at 20:59, wrote: >> > I know I copied and pasted it and I must have done something uncanny. >> > >> > Anyhow this is what the change looks like now (I've retained the Reviewed >> >

Re: [Xen-devel] [PATCH v4 06/34] x86/arm: Add BUGFRAME_NR define and BUILD checks.

2016-03-22 Thread Konrad Rzeszutek Wilk
On Mon, Mar 21, 2016 at 06:49:03AM -0600, Jan Beulich wrote: > >>> On 18.03.16 at 20:59, wrote: > > I know I copied and pasted it and I must have done something uncanny. > > > > Anyhow this is what the change looks like now (I've retained the Reviewed > > and Ack as I think this change is mostly

Re: [Xen-devel] [PATCH v4 06/34] x86/arm: Add BUGFRAME_NR define and BUILD checks.

2016-03-21 Thread Jan Beulich
>>> On 18.03.16 at 20:59, wrote: > I know I copied and pasted it and I must have done something uncanny. > > Anyhow this is what the change looks like now (I've retained the Reviewed > and Ack as I think this change is mostly cosmetical in nature?) I think that's okay. > v5: Add Acks, make BUIL

Re: [Xen-devel] [PATCH v4 06/34] x86/arm: Add BUGFRAME_NR define and BUILD checks.

2016-03-19 Thread Konrad Rzeszutek Wilk
On Fri, Mar 18, 2016 at 06:40:31AM -0600, Jan Beulich wrote: > >>> On 15.03.16 at 18:56, wrote: > > --- a/xen/include/asm-arm/bug.h > > +++ b/xen/include/asm-arm/bug.h > > @@ -31,6 +31,7 @@ struct bug_frame { > > #define BUGFRAME_warn 0 > > #define BUGFRAME_bug1 > > #define BUGFRAME_asser

Re: [Xen-devel] [PATCH v4 06/34] x86/arm: Add BUGFRAME_NR define and BUILD checks.

2016-03-18 Thread Julien Grall
Hi Konrad, On 15/03/2016 17:56, Konrad Rzeszutek Wilk wrote: So that we have a nice mechansim to figure out the upper bounds of bug.frames and also catch compiler errors in case one tries to use a higher frame number. Signed-off-by: Konrad Rzeszutek Wilk For the ARM part: Acked-by: Julien G

Re: [Xen-devel] [PATCH v4 06/34] x86/arm: Add BUGFRAME_NR define and BUILD checks.

2016-03-18 Thread Jan Beulich
>>> On 15.03.16 at 18:56, wrote: > --- a/xen/include/asm-arm/bug.h > +++ b/xen/include/asm-arm/bug.h > @@ -31,6 +31,7 @@ struct bug_frame { > #define BUGFRAME_warn 0 > #define BUGFRAME_bug1 > #define BUGFRAME_assert 2 > +#define BUGFRAME_NR 3 > > /* Many versions of GCC doesn't sup

Re: [Xen-devel] [PATCH v4 06/34] x86/arm: Add BUGFRAME_NR define and BUILD checks.

2016-03-15 Thread Andrew Cooper
On 15/03/16 17:56, Konrad Rzeszutek Wilk wrote: > So that we have a nice mechansim to figure out the upper > bounds of bug.frames and also catch compiler errors in case > one tries to use a higher frame number. > > Signed-off-by: Konrad Rzeszutek Wilk > > --- > Cc: Stefano Stabellini > Cc: Julien

[Xen-devel] [PATCH v4 06/34] x86/arm: Add BUGFRAME_NR define and BUILD checks.

2016-03-15 Thread Konrad Rzeszutek Wilk
So that we have a nice mechansim to figure out the upper bounds of bug.frames and also catch compiler errors in case one tries to use a higher frame number. Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper ---