Re: [Xen-devel] [PATCH v4 04/17] x86emul: support {, V}{, U}COMIS{S, D}

2017-03-01 Thread Andrew Cooper
On 01/03/17 14:26, Jan Beulich wrote: >>> +opc = init_prefixes(stub); >>> +opc[0] = b; >>> +opc[1] = modrm; >>> +if ( ea.type == OP_MEM ) >>> +{ >>> +rc = ops->read(ea.mem.seg, ea.mem.off, mmvalp, vex.pfx ? 8 : 4, >>> +

Re: [Xen-devel] [PATCH v4 04/17] x86emul: support {, V}{, U}COMIS{S, D}

2017-03-01 Thread Jan Beulich
>>> On 01.03.17 at 15:16, wrote: > On 28/02/17 12:51, Jan Beulich wrote: >> @@ -5468,6 +5468,55 @@ x86_emulate( >> state->simd_size = simd_none; >> break; >> >> +CASE_SIMD_PACKED_FP(, 0x0f, 0x2e): /* ucomis{s,d} xmm/mem,xmm */ >> +CASE_SIMD_PACKED_FP(_VEX, 0x0f, 0x2

Re: [Xen-devel] [PATCH v4 04/17] x86emul: support {, V}{, U}COMIS{S, D}

2017-03-01 Thread Andrew Cooper
On 28/02/17 12:51, Jan Beulich wrote: > Signed-off-by: Jan Beulich > --- > v4: Add missing copy_REX_VEX(). > v3: Ignore VEX.l. Add fic.exn_raised constraint to invoke_stub() use. > v2: Add missing RET to stub. Generate #UD (instead of simply failing) > when VEX.l is disallowed. > > --- a/xen/a

[Xen-devel] [PATCH v4 04/17] x86emul: support {,V}{,U}COMIS{S,D}

2017-02-28 Thread Jan Beulich
Signed-off-by: Jan Beulich --- v4: Add missing copy_REX_VEX(). v3: Ignore VEX.l. Add fic.exn_raised constraint to invoke_stub() use. v2: Add missing RET to stub. Generate #UD (instead of simply failing) when VEX.l is disallowed. --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/