On Wed, Sep 06, 2017 at 04:02:23PM +0300, Oleksandr Grytsov wrote:
> On Tue, Sep 5, 2017 at 4:04 PM, Wei Liu wrote:
> > On Tue, Sep 05, 2017 at 01:58:53PM +0100, Ian Jackson wrote:
> >> Wei Liu writes ("Re: [PATCH v4 03/13] libxl: add vdispl device"):
> >> > > +rc = snprintf(connector_path, 12
On Tue, Sep 5, 2017 at 4:04 PM, Wei Liu wrote:
> On Tue, Sep 05, 2017 at 01:58:53PM +0100, Ian Jackson wrote:
>> Wei Liu writes ("Re: [PATCH v4 03/13] libxl: add vdispl device"):
>> > > +rc = snprintf(connector_path, 128, "%s/%d", path,
>> > > info->num_connectors);
>>
>> Why not use GCSPRINT
On Tue, Sep 05, 2017 at 01:58:53PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v4 03/13] libxl: add vdispl device"):
> > > +rc = snprintf(connector_path, 128, "%s/%d", path,
> > > info->num_connectors);
>
> Why not use GCSPRINTF ? These statically sized buffers etc. are an
> invi
Wei Liu writes ("Re: [PATCH v4 03/13] libxl: add vdispl device"):
> > +rc = snprintf(connector_path, 128, "%s/%d", path,
> > info->num_connectors);
Why not use GCSPRINTF ? These statically sized buffers etc. are an
invitation to bugs.
Ian.
___
Xe
On Tue, Jul 18, 2017 at 05:25:20PM +0300, Oleksandr Grytsov wrote:
> From: Oleksandr Grytsov
>
> Signed-off-by: Oleksandr Grytsov
> ---
> tools/libxl/Makefile | 2 +-
> tools/libxl/libxl.h | 24 +++
> tools/libxl/libxl_create.c | 1 +
> tools/libx
From: Oleksandr Grytsov
Signed-off-by: Oleksandr Grytsov
---
tools/libxl/Makefile | 2 +-
tools/libxl/libxl.h | 24 +++
tools/libxl/libxl_create.c | 1 +
tools/libxl/libxl_internal.h | 1 +
tools/libxl/libxl_types.idl | 38