Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device

2017-09-06 Thread Wei Liu
On Wed, Sep 06, 2017 at 04:02:23PM +0300, Oleksandr Grytsov wrote: > On Tue, Sep 5, 2017 at 4:04 PM, Wei Liu wrote: > > On Tue, Sep 05, 2017 at 01:58:53PM +0100, Ian Jackson wrote: > >> Wei Liu writes ("Re: [PATCH v4 03/13] libxl: add vdispl device"): > >> > > +rc = snprintf(connector_path, 12

Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device

2017-09-06 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 4:04 PM, Wei Liu wrote: > On Tue, Sep 05, 2017 at 01:58:53PM +0100, Ian Jackson wrote: >> Wei Liu writes ("Re: [PATCH v4 03/13] libxl: add vdispl device"): >> > > +rc = snprintf(connector_path, 128, "%s/%d", path, >> > > info->num_connectors); >> >> Why not use GCSPRINT

Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device

2017-09-05 Thread Wei Liu
On Tue, Sep 05, 2017 at 01:58:53PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH v4 03/13] libxl: add vdispl device"): > > > +rc = snprintf(connector_path, 128, "%s/%d", path, > > > info->num_connectors); > > Why not use GCSPRINTF ? These statically sized buffers etc. are an > invi

Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device

2017-09-05 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v4 03/13] libxl: add vdispl device"): > > +rc = snprintf(connector_path, 128, "%s/%d", path, > > info->num_connectors); Why not use GCSPRINTF ? These statically sized buffers etc. are an invitation to bugs. Ian. ___ Xe

Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device

2017-09-05 Thread Wei Liu
On Tue, Jul 18, 2017 at 05:25:20PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Signed-off-by: Oleksandr Grytsov > --- > tools/libxl/Makefile | 2 +- > tools/libxl/libxl.h | 24 +++ > tools/libxl/libxl_create.c | 1 + > tools/libx

[Xen-devel] [PATCH v4 03/13] libxl: add vdispl device

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.h | 24 +++ tools/libxl/libxl_create.c | 1 + tools/libxl/libxl_internal.h | 1 + tools/libxl/libxl_types.idl | 38