Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-13 Thread Xu, Quan
On May 13, 2016 5:09 PM, Jan Beulich wrote: > >>> On 13.05.16 at 10:04, wrote: > > On May 12, 2016 11:06 PM, Jan Beulich wrote: > >> >>> On 12.05.16 at 16:28, wrote: > >> > On May 10, 2016 2:54 PM, Jan Beulich wrote: > >> >> >>> On 10.05.16 at 05:41, wrote: > >> >> > On May 10, 2016 12:14 AM,

Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-13 Thread Jan Beulich
>>> On 13.05.16 at 10:04, wrote: > On May 12, 2016 11:06 PM, Jan Beulich wrote: >> >>> On 12.05.16 at 16:28, wrote: >> > On May 10, 2016 2:54 PM, Jan Beulich wrote: >> >> >>> On 10.05.16 at 05:41, wrote: >> >> > On May 10, 2016 12:14 AM, Jan Beulich wrote: >> >> >> >>> On 06.05.16 at 10:54,

Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-13 Thread Xu, Quan
On May 12, 2016 11:06 PM, Jan Beulich wrote: > >>> On 12.05.16 at 16:28, wrote: > > On May 10, 2016 2:54 PM, Jan Beulich wrote: > >> >>> On 10.05.16 at 05:41, wrote: > >> > On May 10, 2016 12:14 AM, Jan Beulich wrote: > >> >> >>> On 06.05.16 at 10:54, wrote: Jan, Try it again, I hope I have

Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-12 Thread Jan Beulich
>>> On 12.05.16 at 16:28, wrote: > On May 10, 2016 2:54 PM, Jan Beulich wrote: >> >>> On 10.05.16 at 05:41, wrote: >> > On May 10, 2016 12:14 AM, Jan Beulich wrote: >> >> >>> On 06.05.16 at 10:54, wrote: >> For DomU the solution seems quite obvious: Only log a message if the domain >> is not a

Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-12 Thread Xu, Quan
On May 10, 2016 2:54 PM, Jan Beulich wrote: > >>> On 10.05.16 at 05:41, wrote: > > On May 10, 2016 12:14 AM, Jan Beulich wrote: > >> >>> On 06.05.16 at 10:54, wrote: > For DomU the solution seems quite obvious: Only log a message if the domain > is not already marked crashed. Jan, I am still c

Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-10 Thread Jan Beulich
>>> On 10.05.16 at 10:20, wrote: > On May 10, 2016 4:03 PM, Jan Beulich wrote: >> But please - as said - also avoid logging any message for already dying >> domains. >> > > > Kept Kevin's opinion for later, I hope I have got your point as below: > ... > +rc = hd->platform_ops->unmap_page(d

Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-10 Thread Xu, Quan
On May 10, 2016 4:03 PM, Jan Beulich wrote: > >>> On 10.05.16 at 09:53, wrote: > > +rc = hd->platform_ops->unmap_page(d, gfn); > > + > > +if ( unlikely(rc) ) > > +{ > > +if ( printk_ratelimit() ) > > +printk(XENLOG_ERR > > + "iommu_unmap_page: IOM

Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-10 Thread Jan Beulich
>>> On 10.05.16 at 09:53, wrote: > +rc = hd->platform_ops->unmap_page(d, gfn); > + > +if ( unlikely(rc) ) > +{ > +if ( printk_ratelimit() ) > +printk(XENLOG_ERR > + "iommu_unmap_page: IOMMU unmapping gfn %#lx failed for > dom%d.", > +

Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-10 Thread Xu, Quan
On May 10, 2016 2:54 PM, Jan Beulich wrote: > >>> On 10.05.16 at 05:41, wrote: > > On May 10, 2016 12:14 AM, Jan Beulich wrote: > >> >>> On 06.05.16 at 10:54, wrote: > >> > --- a/xen/drivers/passthrough/iommu.c > >> > +++ b/xen/drivers/passthrough/iommu.c > >> > @@ -240,21 +240,47 @@ int iommu_

Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-09 Thread Jan Beulich
>>> On 10.05.16 at 05:41, wrote: > On May 10, 2016 12:14 AM, Jan Beulich wrote: >> >>> On 06.05.16 at 10:54, wrote: >> > --- a/xen/drivers/passthrough/iommu.c >> > +++ b/xen/drivers/passthrough/iommu.c >> > @@ -240,21 +240,47 @@ int iommu_map_page(struct domain *d, >> unsigned long gfn, unsigned

Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-09 Thread Xu, Quan
On May 10, 2016 12:14 AM, Jan Beulich wrote: > >>> On 06.05.16 at 10:54, wrote: > > --- a/xen/drivers/passthrough/iommu.c > > +++ b/xen/drivers/passthrough/iommu.c > > @@ -240,21 +240,47 @@ int iommu_map_page(struct domain *d, > unsigned long gfn, unsigned long mfn, > > unsign

Re: [Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-09 Thread Jan Beulich
>>> On 06.05.16 at 10:54, wrote: > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -240,21 +240,47 @@ int iommu_map_page(struct domain *d, unsigned long gfn, > unsigned long mfn, > unsigned int flags) > { > const struct domain_iommu *hd

[Xen-devel] [PATCH v4 02/10] IOMMU: handle IOMMU mapping and unmapping failures

2016-05-06 Thread Quan Xu
Treat IOMMU mapping and unmapping failures as a fatal to the domain (with the exception of the hardware domain). If IOMMU mapping and unmapping failed, crash the domain (with the exception of the hardware domain) and propagate the error up to the call trees. Signed-off-by: Quan Xu Reviewed-by: K