Re: [Xen-devel] [PATCH v4] xen/arm64: check XSM Magic from the second unknown module.

2016-04-05 Thread Fu Wei
Hi Jan, On 5 April 2016 at 22:16, Jan Beulich wrote: On 05.04.16 at 15:38, wrote: >> --- a/xen/xsm/xsm_core.c >> +++ b/xen/xsm/xsm_core.c >> @@ -19,6 +19,8 @@ >> >> #ifdef CONFIG_XSM >> >> +#include > > This is not a good idea. Note how xsm_policy.c limits this inclusion to > the CONFIG_H

Re: [Xen-devel] [PATCH v4] xen/arm64: check XSM Magic from the second unknown module.

2016-04-05 Thread Jan Beulich
>>> On 05.04.16 at 15:38, wrote: > --- a/xen/xsm/xsm_core.c > +++ b/xen/xsm/xsm_core.c > @@ -19,6 +19,8 @@ > > #ifdef CONFIG_XSM > > +#include This is not a good idea. Note how xsm_policy.c limits this inclusion to the CONFIG_HAS_DEVICE_TREE case only, which is the least that should be done

[Xen-devel] [PATCH v4] xen/arm64: check XSM Magic from the second unknown module.

2016-04-05 Thread fu . wei
From: Fu Wei This patch adds a has_xsm_magic helper function for detecting XSM from the second unknown module. If Xen can't get the kind of module from compatible, we guess the kind of these unknowns respectively: (1) The first unknown must be kernel. (2) Detect the XSM Magic from the 2n