Re: [Xen-devel] [PATCH v4] x86/HVM: make hvm_efer_valid() honor guest features

2015-01-22 Thread Andrew Cooper
On 22/01/15 09:02, Jan Beulich wrote: On 21.01.15 at 21:08, wrote: >> On 19/01/15 15:12, Jan Beulich wrote: >>> Following the earlier similar change validating CR4 modifications. >>> >>> Note that this requires a non-obvious adjustment to hvm_cpuid(): On >>> 32-bit hosts/tool stacks, the SYSC

Re: [Xen-devel] [PATCH v4] x86/HVM: make hvm_efer_valid() honor guest features

2015-01-22 Thread Jan Beulich
>>> On 21.01.15 at 21:08, wrote: > On 19/01/15 15:12, Jan Beulich wrote: >> Following the earlier similar change validating CR4 modifications. >> >> Note that this requires a non-obvious adjustment to hvm_cpuid(): On >> 32-bit hosts/tool stacks, the SYSCALL feature flag will be seen clear >> on In

Re: [Xen-devel] [PATCH v4] x86/HVM: make hvm_efer_valid() honor guest features

2015-01-21 Thread Andrew Cooper
On 19/01/15 15:12, Jan Beulich wrote: > Following the earlier similar change validating CR4 modifications. > > Note that this requires a non-obvious adjustment to hvm_cpuid(): On > 32-bit hosts/tool stacks, the SYSCALL feature flag will be seen clear > on Intel CPUs, yet 64-bit guests legitimately

[Xen-devel] [PATCH v4] x86/HVM: make hvm_efer_valid() honor guest features

2015-01-19 Thread Jan Beulich
Following the earlier similar change validating CR4 modifications. Note that this requires a non-obvious adjustment to hvm_cpuid(): On 32-bit hosts/tool stacks, the SYSCALL feature flag will be seen clear on Intel CPUs, yet 64-bit guests legitimately expect the feature for be available. Mimic hard