Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Andrew Cooper
On 10/02/15 16:30, Jan Beulich wrote: Boris Ostrovsky 02/10/15 4:07 PM >>> >> On 02/10/2015 09:54 AM, Andrew Cooper wrote: >>> copy_to/from_guest() is not expensive. It is a straight memcpy with an >>> extable guards for pagefaults. >> True, but still why do this inside a loop? xmalloc() of

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Jan Beulich
>>> Boris Ostrovsky 02/10/15 4:07 PM >>> >On 02/10/2015 09:54 AM, Andrew Cooper wrote: >> copy_to/from_guest() is not expensive. It is a straight memcpy with an >> extable guards for pagefaults. > >True, but still why do this inside a loop? xmalloc() of less than a page >is not that expensive, i

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Boris Ostrovsky
On 02/10/2015 09:54 AM, Andrew Cooper wrote: On 10/02/15 14:45, Boris Ostrovsky wrote: On 02/10/2015 06:13 AM, Andrew Cooper wrote: On 09/02/15 20:04, Boris Ostrovsky wrote: Signed-off-by: Boris Ostrovsky --- xen/common/sysctl.c | 73 +++

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Andrew Cooper
On 10/02/15 14:45, Boris Ostrovsky wrote: > > On 02/10/2015 06:13 AM, Andrew Cooper wrote: >> On 09/02/15 20:04, Boris Ostrovsky wrote: >>> Signed-off-by: Boris Ostrovsky >>> --- >>> xen/common/sysctl.c | 73 >>> +++ >>> xen/include/public/sysct

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Boris Ostrovsky
On 02/10/2015 06:13 AM, Andrew Cooper wrote: On 09/02/15 20:04, Boris Ostrovsky wrote: Signed-off-by: Boris Ostrovsky --- xen/common/sysctl.c | 73 +++ xen/include/public/sysctl.h | 29 + 2 files changed, 102 insertions(+)

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Boris Ostrovsky
On 02/10/2015 05:26 AM, Robert Elz wrote: Date:Mon, 9 Feb 2015 15:04:32 -0500 From:Boris Ostrovsky Message-ID: <1423512275-6531-5-git-send-email-boris.ostrov...@oracle.com> | +num_devs = ti->num_devs - ti->first_dev; | + | +if ( guest_

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Andrew Cooper
On 09/02/15 20:04, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky > --- > xen/common/sysctl.c | 73 > +++ > xen/include/public/sysctl.h | 29 + > 2 files changed, 102 insertions(+), 0 deletions(-) > > diff --git a/xen/c

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Robert Elz
Date:Mon, 9 Feb 2015 15:04:32 -0500 From:Boris Ostrovsky Message-ID: <1423512275-6531-5-git-send-email-boris.ostrov...@oracle.com> | +num_devs = ti->num_devs - ti->first_dev; | + | +if ( guest_handle_is_null(ti->devs) || | + guest

[Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-09 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- xen/common/sysctl.c | 73 +++ xen/include/public/sysctl.h | 29 + 2 files changed, 102 insertions(+), 0 deletions(-) diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c index 30c5806..ea6557