Re: [Xen-devel] [PATCH v3 3/7] xen: credit2: group the runq manipulating functions.

2017-03-01 Thread Dario Faggioli
On Tue, 2017-02-28 at 15:34 +0100, Dario Faggioli wrote: > On Tue, 2017-02-28 at 13:55 +, Andrew Cooper wrote: > > On 28/02/17 11:52, Dario Faggioli wrote: > > > +static inline bool_t same_node(unsigned int cpua, unsigned int > > > cpub) > > > > s/bool_t/bool/g > > > Oh.. Yes, you're right. S

Re: [Xen-devel] [PATCH v3 3/7] xen: credit2: group the runq manipulating functions.

2017-02-28 Thread Dario Faggioli
On Tue, 2017-02-28 at 13:55 +, Andrew Cooper wrote: > On 28/02/17 11:52, Dario Faggioli wrote: > > > > +static inline bool_t same_node(unsigned int cpua, unsigned int > > cpub) > > s/bool_t/bool/g > Oh.. Yes, you're right. Sorry! > > + > > +if ( unlikely(tb_init_done) ) > > +{ > > +

Re: [Xen-devel] [PATCH v3 3/7] xen: credit2: group the runq manipulating functions.

2017-02-28 Thread Andrew Cooper
On 28/02/17 11:52, Dario Faggioli wrote: > +static inline bool_t same_node(unsigned int cpua, unsigned int cpub) s/bool_t/bool/g > > + > +if ( unlikely(tb_init_done) ) > +{ > +struct { > +unsigned rqi:16, max_weight:16; More commonly known as uint16_t :) ~Andrew ___

[Xen-devel] [PATCH v3 3/7] xen: credit2: group the runq manipulating functions.

2017-02-28 Thread Dario Faggioli
So that they're all close among each other, and also near to the comment describind the runqueue organization (which is also moved). No functional change intended. Signed-off-by: Dario Faggioli --- Cc: George Dunlap Cc: Anshul Makkar --- Changes from v2: * don't move the 'credit2_runqueue' opt