Re: [Xen-devel] [PATCH v3 3/4] x86/vvmx: correctly emulate VMWRITE

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 11:09, wrote: > --- a/xen/arch/x86/hvm/vmx/vvmx.c > +++ b/xen/arch/x86/hvm/vmx/vvmx.c > @@ -305,6 +305,19 @@ void set_vvmcs_real(const struct vcpu *v, u32 encoding, > u64 val) > virtual_vmcs_vmwrite(v, encoding, val); > } > > +enum vmx_insn_errno set_vvmcs_virtual_safe(

[Xen-devel] [PATCH v3 3/4] x86/vvmx: correctly emulate VMWRITE

2017-02-08 Thread Sergey Dyasli
There is an issue with the original __vmwrite() in nested vmx mode: emulation of a guest's VMWRITE with invalid arguments leads to BUG(). Fix this by using vmwrite_safe() and reporting any kind of VMfail back to the guest. A new safe versions of set_vvmcs() macro and related functions are introdu