Re: [Xen-devel] [PATCH v3 21/28] tools/libxl: Infrastructure for writing a v2 stream

2015-07-13 Thread Andrew Cooper
On 13/07/15 16:47, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH v3 21/28] tools/libxl: Infrastructure for > writing a v2 stream"): >> On 13/07/15 16:21, Ian Jackson wrote: >>> Sadly this pattern is not correct. I don't think this initialisation >>> ensures that the memory in hdr is all-

Re: [Xen-devel] [PATCH v3 21/28] tools/libxl: Infrastructure for writing a v2 stream

2015-07-13 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v3 21/28] tools/libxl: Infrastructure for writing a v2 stream"): > On 13/07/15 16:21, Ian Jackson wrote: > > Sadly this pattern is not correct. I don't think this initialisation > > ensures that the memory in hdr is all-bits-0. > > It guarantees that all object

Re: [Xen-devel] [PATCH v3 21/28] tools/libxl: Infrastructure for writing a v2 stream

2015-07-13 Thread Andrew Cooper
On 13/07/15 16:21, Ian Jackson wrote: > Andrew Cooper writes ("[PATCH v3 21/28] tools/libxl: Infrastructure for > writing a v2 stream"): > ... >> +void libxl__stream_write_start(libxl__egc *egc, >> + libxl__stream_write_state *stream) >> +{ >> +libxl__datacopier_s

Re: [Xen-devel] [PATCH v3 21/28] tools/libxl: Infrastructure for writing a v2 stream

2015-07-13 Thread Ian Jackson
Andrew Cooper writes ("[PATCH v3 21/28] tools/libxl: Infrastructure for writing a v2 stream"): ... > +void libxl__stream_write_start(libxl__egc *egc, > + libxl__stream_write_state *stream) > +{ > +libxl__datacopier_state *dc = &stream->dc; > +STATE_AO_GC(strea

Re: [Xen-devel] [PATCH v3 21/28] tools/libxl: Infrastructure for writing a v2 stream

2015-07-13 Thread Ian Jackson
Andrew Cooper writes ("[PATCH v3 21/28] tools/libxl: Infrastructure for writing a v2 stream"): ... > +libxl__carefd_begin(); > +int readfd = open(filename, O_RDONLY); > +if (readfd == -1) { > +rc = ERROR_FAIL; > +LOGE(ERROR, "unable to open %s", filename); > +li

[Xen-devel] [PATCH v3 21/28] tools/libxl: Infrastructure for writing a v2 stream

2015-07-13 Thread Andrew Cooper
From: Ross Lagerwall This contains the event machinery and state machines to write non-checkpointed migration v2 stream (with the exception of the xc_domain_save() handling which is spliced later in a bisectable way). Signed-off-by: Ross Lagerwall Signed-off-by: Andrew Cooper CC: Ian Campbell