Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-02-23 Thread Julien Grall
Hi Ian, On 23/02/15 15:31, Ian Campbell wrote: > On Fri, 2015-02-20 at 17:45 +, Julien Grall wrote: >> On 20/02/15 16:58, Ian Campbell wrote: >>> On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: This new function will correctly initialize the IOMMU page table for the current do

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-02-23 Thread Ian Campbell
On Fri, 2015-02-20 at 17:45 +, Julien Grall wrote: > On 20/02/15 16:58, Ian Campbell wrote: > > On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > >> This new function will correctly initialize the IOMMU page table for the > >> current domain. > >> > >> Also use it in iommu_assign_dt_devi

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-02-20 Thread Julien Grall
On 20/02/15 16:58, Ian Campbell wrote: > On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: >> This new function will correctly initialize the IOMMU page table for the >> current domain. >> >> Also use it in iommu_assign_dt_device even though the current IOMMU >> implementation on ARM shares P2

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-02-20 Thread Ian Campbell
On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: > This new function will correctly initialize the IOMMU page table for the > current domain. > > Also use it in iommu_assign_dt_device even though the current IOMMU > implementation on ARM shares P2M with the processor. > > Signed-off-by: Jul

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-01-21 Thread Jan Beulich
>>> On 21.01.15 at 15:22, wrote: > On 21/01/15 14:13, Jan Beulich wrote: > On 21.01.15 at 13:13, wrote: >>> iommu_dom0_strict is always set to 1 when IOMMU is used on ARM (see >>> check_hwdom_reqs). >>> >>> Futhermore, we always share the page table with the processor, so we >>> never need to

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-01-21 Thread Julien Grall
On 21/01/15 14:13, Jan Beulich wrote: On 21.01.15 at 13:13, wrote: >> Hi Jan, >> >> On 21/01/15 10:48, Jan Beulich wrote: >> On 21.01.15 at 11:37, wrote: On 21/01/2015 10:23, Jan Beulich wrote: On 20.01.15 at 18:11, wrote: >> While this function is currently only used

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-01-21 Thread Jan Beulich
>>> On 21.01.15 at 13:13, wrote: > Hi Jan, > > On 21/01/15 10:48, Jan Beulich wrote: > On 21.01.15 at 11:37, wrote: >>> On 21/01/2015 10:23, Jan Beulich wrote: >>> On 20.01.15 at 18:11, wrote: > While this function is currently only used for DOM0, this will be used > in a later

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-01-21 Thread Julien Grall
Hi Jan, On 21/01/15 10:48, Jan Beulich wrote: On 21.01.15 at 11:37, wrote: >> On 21/01/2015 10:23, Jan Beulich wrote: >> On 20.01.15 at 18:11, wrote: While this function is currently only used for DOM0, this will be used in a later patch for guest non-PCI passthrough. >>> >>>

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-01-21 Thread Jan Beulich
>>> On 21.01.15 at 11:37, wrote: > On 21/01/2015 10:23, Jan Beulich wrote: > On 20.01.15 at 18:11, wrote: >>> While this function is currently only used for DOM0, this will be used >>> in a later patch for guest non-PCI passthrough. >> >> Okay, but you shouldn't break (or alter in [seemingly]

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-01-21 Thread Julien Grall
On 21/01/2015 10:23, Jan Beulich wrote: On 20.01.15 at 18:11, wrote: On 20/01/15 16:40, Jan Beulich wrote: On 20.01.15 at 15:28, wrote: On 19/01/15 17:02, Jan Beulich wrote: On 13.01.15 at 15:25, wrote: --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tre

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-01-21 Thread Jan Beulich
>>> On 20.01.15 at 18:11, wrote: > On 20/01/15 16:40, Jan Beulich wrote: > On 20.01.15 at 15:28, wrote: >>> On 19/01/15 17:02, Jan Beulich wrote: >>> On 13.01.15 at 15:25, wrote: > --- a/xen/drivers/passthrough/device_tree.c > +++ b/xen/drivers/passthrough/device_tree.c > @@

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-01-20 Thread Julien Grall
On 20/01/15 16:40, Jan Beulich wrote: On 20.01.15 at 15:28, wrote: >> On 19/01/15 17:02, Jan Beulich wrote: >> On 13.01.15 at 15:25, wrote: --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -41,6 +41,10 @@ int iommu_assign_dt_device

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-01-20 Thread Jan Beulich
>>> On 20.01.15 at 15:28, wrote: > On 19/01/15 17:02, Jan Beulich wrote: > On 13.01.15 at 15:25, wrote: >>> --- a/xen/drivers/passthrough/device_tree.c >>> +++ b/xen/drivers/passthrough/device_tree.c >>> @@ -41,6 +41,10 @@ int iommu_assign_dt_device(struct domain *d, struct >>> dt_device_nod

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-01-20 Thread Julien Grall
Hi Jan, On 19/01/15 17:02, Jan Beulich wrote: On 13.01.15 at 15:25, wrote: >> --- a/xen/drivers/passthrough/device_tree.c >> +++ b/xen/drivers/passthrough/device_tree.c >> @@ -41,6 +41,10 @@ int iommu_assign_dt_device(struct domain *d, struct >> dt_device_node *dev) >> if ( !list_empty

Re: [Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-01-19 Thread Jan Beulich
>>> On 13.01.15 at 15:25, wrote: > --- a/xen/drivers/passthrough/device_tree.c > +++ b/xen/drivers/passthrough/device_tree.c > @@ -41,6 +41,10 @@ int iommu_assign_dt_device(struct domain *d, struct > dt_device_node *dev) > if ( !list_empty(&dev->domain_list) ) > goto fail; > > +

[Xen-devel] [PATCH v3 16/24] xen/passthrough: Introduce iommu_construct

2015-01-13 Thread Julien Grall
This new function will correctly initialize the IOMMU page table for the current domain. Also use it in iommu_assign_dt_device even though the current IOMMU implementation on ARM shares P2M with the processor. Signed-off-by: Julien Grall Cc: Jan Beulich --- Changes in v3: - The ASS