Re: [Xen-devel] [PATCH v3 14/16] x86/boot: implement early command line parser in C

2016-06-02 Thread Jan Beulich
>>> On 02.06.16 at 10:15, wrote: > On Fri, May 27, 2016 at 03:33:49AM -0600, Jan Beulich wrote: >> >>> On 25.05.16 at 23:36, wrote: >> > On Wed, May 25, 2016 at 04:33:54AM -0600, Jan Beulich wrote: >> >> >>> On 15.04.16 at 14:33, wrote: >> >> > +/* >> >> > + * Compiler is not able to optimize re

Re: [Xen-devel] [PATCH v3 14/16] x86/boot: implement early command line parser in C

2016-06-02 Thread Daniel Kiper
On Fri, May 27, 2016 at 03:33:49AM -0600, Jan Beulich wrote: > >>> On 25.05.16 at 23:36, wrote: > > On Wed, May 25, 2016 at 04:33:54AM -0600, Jan Beulich wrote: > >> >>> On 15.04.16 at 14:33, wrote: [...] > >> > +/* > >> > + * Compiler is not able to optimize regular strlen() > >> > + * if argu

Re: [Xen-devel] [PATCH v3 14/16] x86/boot: implement early command line parser in C

2016-05-27 Thread Jan Beulich
>>> On 25.05.16 at 23:36, wrote: > On Wed, May 25, 2016 at 04:33:54AM -0600, Jan Beulich wrote: >> >>> On 15.04.16 at 14:33, wrote: >> > --- /dev/null >> > +++ b/xen/arch/x86/boot/cmdline.c >> > @@ -0,0 +1,357 @@ >> > +/* >> > + * Copyright (c) 2015, 2016 Oracle and/or its affiliates. All rights

Re: [Xen-devel] [PATCH v3 14/16] x86/boot: implement early command line parser in C

2016-05-25 Thread Daniel Kiper
On Wed, May 25, 2016 at 04:33:54AM -0600, Jan Beulich wrote: > >>> On 15.04.16 at 14:33, wrote: > > --- a/xen/arch/x86/boot/build32.lds > > +++ b/xen/arch/x86/boot/build32.lds > > @@ -25,6 +25,7 @@ SECTIONS > > *(.text) > > *(.text.*) > > *(.rodata) > > +*(.rodat

Re: [Xen-devel] [PATCH v3 14/16] x86/boot: implement early command line parser in C

2016-05-25 Thread Jan Beulich
>>> On 15.04.16 at 14:33, wrote: > --- a/xen/arch/x86/boot/build32.lds > +++ b/xen/arch/x86/boot/build32.lds > @@ -25,6 +25,7 @@ SECTIONS > *(.text) > *(.text.*) > *(.rodata) > +*(.rodata.*) >} Interesting - didn't you say you don't want this for now? > ---

[Xen-devel] [PATCH v3 14/16] x86/boot: implement early command line parser in C

2016-04-15 Thread Daniel Kiper
Current early command line parser implementation in assembler is very difficult to change to relocatable stuff using segment registers. This requires a lot of changes in very weird and fragile code. So, reimplement this functionality in C. This way code will be relocatable out of the box (without p