Re: [Xen-devel] [PATCH v3 10/16] hvmloader: Load SeaBIOS from hvm_start_info modules

2016-03-03 Thread Anthony PERARD
On Mon, Feb 29, 2016 at 10:02:10AM -0700, Jan Beulich wrote: > >>> On 25.02.16 at 15:56, wrote: > > @@ -127,22 +124,29 @@ static void seabios_setup_e820(void) > > struct e820entry *e820 = scratch_alloc(sizeof(struct e820entry)*16, 0); > > info->e820 = (uint32_t)e820; > > > > +BUG_O

Re: [Xen-devel] [PATCH v3 10/16] hvmloader: Load SeaBIOS from hvm_start_info modules

2016-02-29 Thread Jan Beulich
>>> On 25.02.16 at 15:56, wrote: > @@ -127,22 +124,29 @@ static void seabios_setup_e820(void) > struct e820entry *e820 = scratch_alloc(sizeof(struct e820entry)*16, 0); > info->e820 = (uint32_t)e820; > > +BUG_ON(seabios_config.bios_address == 0); I think this is too lax: Surely thi

[Xen-devel] [PATCH v3 10/16] hvmloader: Load SeaBIOS from hvm_start_info modules

2016-02-25 Thread Anthony PERARD
... and do not include the SeaBIOS ROM into hvmloader anymore. This also fix the dependency on roms.inc, hvmloader.o does not include it. Signed-off-by: Anthony PERARD --- Change in V3: - change makefile to not include seabios roms into roms.inc. - update the struct bios_config with the location