Re: [Xen-devel] [PATCH v3 10/10] libxl: fix caller of libxl_cpupool functions

2015-07-16 Thread Dario Faggioli
On Thu, 2015-07-16 at 11:30 +0200, Juergen Gross wrote: > On 07/16/2015 10:57 AM, Dario Faggioli wrote: > > [Adding Juergen] > > Near miss. You took my old mail address. :-) > Sorry for this! That's what I have in the MUA... Apparently it's never got updated as the most of the mail I sent to you

Re: [Xen-devel] [PATCH v3 10/10] libxl: fix caller of libxl_cpupool functions

2015-07-16 Thread Juergen Gross
On 07/16/2015 11:07 AM, Wei Liu wrote: On Thu, Jul 16, 2015 at 10:57:24AM +0200, Dario Faggioli wrote: [Adding Juergen] On Wed, 2015-07-15 at 18:16 +0100, Wei Liu wrote: On Tue, Jul 14, 2015 at 06:33:22PM +0100, Ian Jackson wrote: Wei Liu writes ("[PATCH v3 10/10] libxl: fix c

Re: [Xen-devel] [PATCH v3 10/10] libxl: fix caller of libxl_cpupool functions

2015-07-16 Thread Juergen Gross
On 07/16/2015 10:57 AM, Dario Faggioli wrote: [Adding Juergen] Near miss. You took my old mail address. :-) On Wed, 2015-07-15 at 18:16 +0100, Wei Liu wrote: On Tue, Jul 14, 2015 at 06:33:22PM +0100, Ian Jackson wrote: Wei Liu writes ("[PATCH v3 10/10] libxl: fix caller of libxl_cpupool f

Re: [Xen-devel] [PATCH v3 10/10] libxl: fix caller of libxl_cpupool functions

2015-07-16 Thread Wei Liu
On Thu, Jul 16, 2015 at 10:57:24AM +0200, Dario Faggioli wrote: > [Adding Juergen] > > On Wed, 2015-07-15 at 18:16 +0100, Wei Liu wrote: > > On Tue, Jul 14, 2015 at 06:33:22PM +0100, Ian Jackson wrote: > > > Wei Liu writes ("[PATCH v3 10/10] libxl: fix caller of libxl_cpupool > > >

Re: [Xen-devel] [PATCH v3 10/10] libxl: fix caller of libxl_cpupool functions

2015-07-16 Thread Dario Faggioli
[Adding Juergen] On Wed, 2015-07-15 at 18:16 +0100, Wei Liu wrote: > On Tue, Jul 14, 2015 at 06:33:22PM +0100, Ian Jackson wrote: > > Wei Liu writes ("[PATCH v3 10/10] libxl: fix caller of libxl_cpupool > > functions"): > > > --- a/tools/libxl/libxl.c > > > +++ b/tools/libxl/libx

Re: [Xen-devel] [PATCH v3 10/10] libxl: fix caller of libxl_cpupool functions

2015-07-15 Thread Wei Liu
On Tue, Jul 14, 2015 at 06:33:22PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH v3 10/10] libxl: fix caller of libxl_cpupool > functions"): > > Coverity complains cpupool_info leaks a string in failure path. Instead > > of fixing that path, we rely on the callers (two public APIs at the > >

Re: [Xen-devel] [PATCH v3 10/10] libxl: fix caller of libxl_cpupool functions

2015-07-14 Thread Ian Jackson
Wei Liu writes ("[PATCH v3 10/10] libxl: fix caller of libxl_cpupool functions"): > Coverity complains cpupool_info leaks a string in failure path. Instead > of fixing that path, we rely on the callers (two public APIs at the > moment) of cpupool_info correctly call libxl_cpupoolinfo_dispose in >

[Xen-devel] [PATCH v3 10/10] libxl: fix caller of libxl_cpupool functions

2015-07-14 Thread Wei Liu
Coverity complains cpupool_info leaks a string in failure path. Instead of fixing that path, we rely on the callers (two public APIs at the moment) of cpupool_info correctly call libxl_cpupoolinfo_dispose in their failure path to dispose of any resources. That involves: 1. Call _init and _dispose