Re: [Xen-devel] [PATCH v3 1/3] xen: add warning infrastructure

2016-06-23 Thread Jan Beulich
>>> On 23.06.16 at 13:17, wrote: > On Thu, Jun 23, 2016 at 11:37:43AM +0100, Wei Liu wrote: > [...] >> The warning text (multiple lines) is added as one single string, which >> means we can't trivially add leading stars at the beginning of each >> line. >> >> I don't feel like arguing over how th

Re: [Xen-devel] [PATCH v3 1/3] xen: add warning infrastructure

2016-06-23 Thread Andrew Cooper
On 23/06/16 12:17, Wei Liu wrote: > On Thu, Jun 23, 2016 at 11:37:43AM +0100, Wei Liu wrote: > [...] >> The warning text (multiple lines) is added as one single string, which >> means we can't trivially add leading stars at the beginning of each >> line. >> >> I don't feel like arguing over how the

Re: [Xen-devel] [PATCH v3 1/3] xen: add warning infrastructure

2016-06-23 Thread Wei Liu
On Thu, Jun 23, 2016 at 11:37:43AM +0100, Wei Liu wrote: [...] > The warning text (multiple lines) is added as one single string, which > means we can't trivially add leading stars at the beginning of each > line. > > I don't feel like arguing over how the text would look like, so if > something l

Re: [Xen-devel] [PATCH v3 1/3] xen: add warning infrastructure

2016-06-23 Thread Wei Liu
On Wed, Jun 22, 2016 at 09:35:51AM -0600, Jan Beulich wrote: > >>> On 20.06.16 at 18:30, wrote: > > @@ -1582,6 +1583,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) > > > > init_constructors(); > > > > +warning_print(); > > + > > console_endboot(); > > What about an A

Re: [Xen-devel] [PATCH v3 1/3] xen: add warning infrastructure

2016-06-22 Thread Jan Beulich
>>> On 20.06.16 at 18:30, wrote: > @@ -1582,6 +1583,8 @@ void __init noreturn __start_xen(unsigned long mbi_p) > > init_constructors(); > > +warning_print(); > + > console_endboot(); What about an ARM equivalent? Perhaps put this in console_endboot()? > --- a/xen/common/Makefil

[Xen-devel] [PATCH v3 1/3] xen: add warning infrastructure

2016-06-20 Thread Wei Liu
Use an array to keep track of warning text, provide a function to add warning text to track. Print warnings (if any) right before finishing using the console. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/setup.c | 3 +++ xen/common/Makefile | 1 +