Re: [Xen-devel] [PATCH v3 1/3] xen: RCU: let the RCU idle timer handler run

2017-10-09 Thread Dario Faggioli
On Mon, 2017-10-09 at 03:49 -0600, Jan Beulich wrote: > > > > On 28.09.17 at 19:06, wrote: > > > With at least the latter addressed > Reviewed-by: Jan Beulich > Of course both should be easy to take care of while committing, > should no other reason arise for sending v4. > Which, AFAICS, you've

Re: [Xen-devel] [PATCH v3 1/3] xen: RCU: let the RCU idle timer handler run

2017-10-09 Thread Jan Beulich
>>> On 28.09.17 at 19:06, wrote: > --- a/xen/common/timer.c > +++ b/xen/common/timer.c > @@ -332,6 +332,23 @@ void stop_timer(struct timer *timer) > } > > > +bool timer_expires_before(struct timer *timer, s_time_t t) > +{ > +unsigned long flags; > +bool ret = false; > + > +if ( !t

[Xen-devel] [PATCH v3 1/3] xen: RCU: let the RCU idle timer handler run

2017-09-28 Thread Dario Faggioli
If stop_timer() is called between when the RCU idle timer's interrupt arrives (and TIMER_SOFTIRQ is raised) and when softirqs are checked and handled, the timer is deactivated, and the handler never runs. This happens to the RCU idle timer because stop_timer() is called on it during the wakeup fro