Re: [Xen-devel] [PATCH v3 1/2] x86: simplify non‑atomic bitops

2015-03-26 Thread Andrew Cooper
On 26/03/15 08:00, Jan Beulich wrote: On 25.03.15 at 18:49, wrote: On 20/03/15 14:53, Jan Beulich wrote: - being non-atomic, their pointer arguments shouldn't be volatile- qualified - their (half fake) memory operands can be a single "+m" instead of being both an output and an input S

Re: [Xen-devel] [PATCH v3 1/2] x86: simplify non‑atomic bitops

2015-03-26 Thread Jan Beulich
>>> On 25.03.15 at 18:49, wrote: > On 20/03/15 14:53, Jan Beulich wrote: >> - being non-atomic, their pointer arguments shouldn't be volatile- >>qualified >> - their (half fake) memory operands can be a single "+m" instead of >>being both an output and an input >> >> Signed-off-by: Jan Beu

Re: [Xen-devel] [PATCH v3 1/2] x86: simplify non‑atomic bitops

2015-03-25 Thread Andrew Cooper
On 20/03/15 14:53, Jan Beulich wrote: - being non-atomic, their pointer arguments shouldn't be volatile- qualified - their (half fake) memory operands can be a single "+m" instead of being both an output and an input Signed-off-by: Jan Beulich After further consideration, would it not b

[Xen-devel] [PATCH v3 1/2] x86: simplify non‑atomic bitops

2015-03-20 Thread Jan Beulich
- being non-atomic, their pointer arguments shouldn't be volatile- qualified - their (half fake) memory operands can be a single "+m" instead of being both an output and an input Signed-off-by: Jan Beulich --- v3: Replace ADDR uses by *(int *)addr to not re-gain the volatile qualifier. v2