Re: [Xen-devel] [PATCH v3 09/23] xsplice: Add support for bug frames. (v4)

2016-02-24 Thread Andrew Cooper
On 24/02/16 16:22, Konrad Rzeszutek Wilk wrote: > . snip.. >> There is a neater way of doing this, which doesn't involve having "if ( >> regular ) else if ( xsplice )" logic chains through the code. > s/chains/chain/ > > There is only one that uses the 'xsplice' name in it:-) > > The other two are

Re: [Xen-devel] [PATCH v3 09/23] xsplice: Add support for bug frames. (v4)

2016-02-24 Thread Konrad Rzeszutek Wilk
On Tue, Feb 16, 2016 at 07:35:32PM +, Andrew Cooper wrote: > On 12/02/16 18:05, Konrad Rzeszutek Wilk wrote: > > diff --git a/xen/common/symbols.c b/xen/common/symbols.c > > index a59c59d..bf5623f 100644 > > --- a/xen/common/symbols.c > > +++ b/xen/common/symbols.c > > @@ -17,6 +17,7 @@ > > #i

Re: [Xen-devel] [PATCH v3 09/23] xsplice: Add support for bug frames. (v4)

2016-02-24 Thread Konrad Rzeszutek Wilk
. snip.. > There is a neater way of doing this, which doesn't involve having "if ( > regular ) else if ( xsplice )" logic chains through the code. s/chains/chain/ There is only one that uses the 'xsplice' name in it:-) The other two are wrapped with the 'is_patch'. > > Given a > > struct virtu

Re: [Xen-devel] [PATCH v3 09/23] xsplice: Add support for bug frames. (v4)

2016-02-16 Thread Andrew Cooper
On 12/02/16 18:05, Konrad Rzeszutek Wilk wrote: > diff --git a/xen/common/symbols.c b/xen/common/symbols.c > index a59c59d..bf5623f 100644 > --- a/xen/common/symbols.c > +++ b/xen/common/symbols.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include >

[Xen-devel] [PATCH v3 09/23] xsplice: Add support for bug frames. (v4)

2016-02-12 Thread Konrad Rzeszutek Wilk
From: Ross Lagerwall Add support for handling bug frames contained with xsplice modules. If a trap occurs search either the kernel bug table or an applied payload's bug table depending on the instruction pointer. Signed-off-by: Ross Lagerwall Signed-off-by: Konrad Rzeszutek Wilk --- v2:- s/mod