Re: [Xen-devel] [PATCH v3 06/26] ARM: GICv3 ITS: introduce device mapping

2017-04-03 Thread Julien Grall
Hi Andre, Mostly repeating my comments from the previous version. On 31/03/17 19:05, Andre Przywara wrote: [...] +static int its_send_cmd_mapd(struct host_its *its, uint32_t deviceid, + uint8_t size_bits, paddr_t itt_addr, bool valid) +{ +uint64_t cmd[4]; + +

Re: [Xen-devel] [PATCH v3 06/26] ARM: GICv3 ITS: introduce device mapping

2017-04-03 Thread Julien Grall
On 01/04/17 09:01, Vijay Kilari wrote: Hi Andre, Hi Vijay, On Fri, Mar 31, 2017 at 11:35 PM, Andre Przywara wrote: +/* An Interrupt Translation Table needs to be 256-byte aligned. */ +itt_addr = _xzalloc(nr_events * hw_its->itte_size, 256); As I mentioned, in previous versio

Re: [Xen-devel] [PATCH v3 06/26] ARM: GICv3 ITS: introduce device mapping

2017-04-01 Thread Vijay Kilari
Hi Andre, On Fri, Mar 31, 2017 at 11:35 PM, Andre Przywara wrote: > The ITS uses device IDs to map LPIs to a device. Dom0 will later use > those IDs, which we directly pass on to the host. > For this we have to map each device that Dom0 may request to a host > ITS device with the same identifier.

Re: [Xen-devel] [PATCH v3 06/26] ARM: GICv3 ITS: introduce device mapping

2017-03-31 Thread Stefano Stabellini
On Fri, 31 Mar 2017, Andre Przywara wrote: > The ITS uses device IDs to map LPIs to a device. Dom0 will later use > those IDs, which we directly pass on to the host. > For this we have to map each device that Dom0 may request to a host > ITS device with the same identifier. > Allocate the respectiv

[Xen-devel] [PATCH v3 06/26] ARM: GICv3 ITS: introduce device mapping

2017-03-31 Thread Andre Przywara
The ITS uses device IDs to map LPIs to a device. Dom0 will later use those IDs, which we directly pass on to the host. For this we have to map each device that Dom0 may request to a host ITS device with the same identifier. Allocate the respective memory and enter each device into an rbtree to late