Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-07-18 Thread Wei Liu
On Wed, Jul 12, 2017 at 07:13:34PM +0300, Oleksandr Grytsov wrote: > On Tue, Jul 4, 2017 at 12:41 PM, Oleksandr Grytsov wrote: > >>> >> > > I don't see exiting device ported to the new framework, why? > >>> >> > > >>> >> > Good question. I think it is a little dangerous and may introduce > >>> >>

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-07-12 Thread Oleksandr Grytsov
On Tue, Jul 4, 2017 at 12:41 PM, Oleksandr Grytsov wrote: >>> >> > > I don't see exiting device ported to the new framework, why? >>> >> > >>> >> > Good question. I think it is a little dangerous and may introduce >>> >> > regression. >>> >> > But definitely it should be done. I can do these chan

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-07-12 Thread Wei Liu
On Mon, Jul 10, 2017 at 03:41:28PM +0300, Oleksandr Grytsov wrote: > On Fri, Jul 7, 2017 at 1:56 PM, Oleksandr Grytsov wrote: > > On Fri, Jul 7, 2017 at 1:32 PM, Wei Liu wrote: > >> On Fri, Jul 07, 2017 at 01:29:39PM +0300, Oleksandr Grytsov wrote: > >> > Actually my the first patch probably was

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-07-10 Thread Oleksandr Grytsov
On Fri, Jul 7, 2017 at 1:56 PM, Oleksandr Grytsov wrote: > On Fri, Jul 7, 2017 at 1:32 PM, Wei Liu wrote: >> On Fri, Jul 07, 2017 at 01:29:39PM +0300, Oleksandr Grytsov wrote: >> > Actually my the first patch probably was done on the old codebase >>> > which doesn't have locking in add function.

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-07-07 Thread Oleksandr Grytsov
On Fri, Jul 7, 2017 at 1:32 PM, Wei Liu wrote: > On Fri, Jul 07, 2017 at 01:29:39PM +0300, Oleksandr Grytsov wrote: > > Actually my the first patch probably was done on the old codebase >> > which doesn't have locking in add function. So new approach is >> > definitely wrong and I will use former

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-07-07 Thread Wei Liu
On Fri, Jul 07, 2017 at 01:29:39PM +0300, Oleksandr Grytsov wrote: > Actually my the first patch probably was done on the old codebase > > which doesn't have locking in add function. So new approach is > > definitely wrong and I will use former one. > > Please ignore my above comment. Actually it

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-07-07 Thread Oleksandr Grytsov
On Fri, Jul 7, 2017 at 12:49 PM, Oleksandr Grytsov wrote: > On Thu, Jul 6, 2017 at 6:51 PM, Wei Liu wrote: >> On Tue, Jun 27, 2017 at 01:03:20PM +0300, Oleksandr Grytsov wrote: >>> From: Oleksandr Grytsov >>> >>> Add libxl__device_add functio. >>> Almost all devices have similar libxl__device_xx

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-07-07 Thread Oleksandr Grytsov
On Thu, Jul 6, 2017 at 6:51 PM, Wei Liu wrote: > On Tue, Jun 27, 2017 at 01:03:20PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Add libxl__device_add functio. >> Almost all devices have similar libxl__device__add function. >> This generic function implements same function

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-07-06 Thread Wei Liu
On Tue, Jun 27, 2017 at 01:03:20PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Add libxl__device_add functio. > Almost all devices have similar libxl__device__add function. > This generic function implements same functionality but > using the device handling framework. The d

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-07-04 Thread Oleksandr Grytsov
>> >> > > I don't see exiting device ported to the new framework, why? >> >> > >> >> > Good question. I think it is a little dangerous and may introduce >> >> > regression. >> >> > But definitely it should be done. I can do these changes but I don't >> >> > have >> >> > visibility how to check ea

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-07-03 Thread Wei Liu
On Mon, Jul 03, 2017 at 03:53:08PM +0300, Oleksandr Grytsov wrote: > On Fri, Jun 30, 2017 at 5:18 PM, Wei Liu wrote: > > On Fri, Jun 30, 2017 at 03:16:38PM +0100, Wei Liu wrote: > >> On Fri, Jun 30, 2017 at 04:24:23PM +0300, Oleksandr Grytsov wrote: > >> > On Thu, Jun 29, 2017 at 8:36 PM, Wei Liu

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-07-03 Thread Oleksandr Grytsov
On Fri, Jun 30, 2017 at 5:18 PM, Wei Liu wrote: > On Fri, Jun 30, 2017 at 03:16:38PM +0100, Wei Liu wrote: >> On Fri, Jun 30, 2017 at 04:24:23PM +0300, Oleksandr Grytsov wrote: >> > On Thu, Jun 29, 2017 at 8:36 PM, Wei Liu wrote: >> > > On Tue, Jun 27, 2017 at 01:03:20PM +0300, Oleksandr Grytsov

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-06-30 Thread Wei Liu
On Fri, Jun 30, 2017 at 03:16:38PM +0100, Wei Liu wrote: > On Fri, Jun 30, 2017 at 04:24:23PM +0300, Oleksandr Grytsov wrote: > > On Thu, Jun 29, 2017 at 8:36 PM, Wei Liu wrote: > > > On Tue, Jun 27, 2017 at 01:03:20PM +0300, Oleksandr Grytsov wrote: > > >> From: Oleksandr Grytsov > > >> > > >> A

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-06-30 Thread Wei Liu
On Fri, Jun 30, 2017 at 04:24:23PM +0300, Oleksandr Grytsov wrote: > On Thu, Jun 29, 2017 at 8:36 PM, Wei Liu wrote: > > On Tue, Jun 27, 2017 at 01:03:20PM +0300, Oleksandr Grytsov wrote: > >> From: Oleksandr Grytsov > >> > >> Add libxl__device_add functio. > > > > function > > > >> Almost all de

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-06-30 Thread Oleksandr Grytsov
On Thu, Jun 29, 2017 at 8:36 PM, Wei Liu wrote: > On Tue, Jun 27, 2017 at 01:03:20PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Add libxl__device_add functio. > > function > >> Almost all devices have similar libxl__device__add function. >> This generic function implemen

Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-06-29 Thread Wei Liu
On Tue, Jun 27, 2017 at 01:03:20PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Add libxl__device_add functio. function > Almost all devices have similar libxl__device__add function. > This generic function implements same functionality but > using the device handling frame

[Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

2017-06-27 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add libxl__device_add functio. Almost all devices have similar libxl__device__add function. This generic function implements same functionality but using the device handling framework. The device specific part this is setting xen store configuration. This part is moved