Re: [Xen-devel] [PATCH v3 03/24] x86/emul: Simplfy emulation state setup

2016-12-07 Thread George Dunlap
> On Nov 30, 2016, at 9:50 PM, Andrew Cooper wrote: > > The current code to set up emulation state is ad-hoc and error prone. > > * Consistently zero all emulation state structures. > * Avoid explicitly initialising some state to 0. > * Explicitly identify all input and output state in x86_emul

[Xen-devel] [PATCH v3 03/24] x86/emul: Simplfy emulation state setup

2016-11-30 Thread Andrew Cooper
The current code to set up emulation state is ad-hoc and error prone. * Consistently zero all emulation state structures. * Avoid explicitly initialising some state to 0. * Explicitly identify all input and output state in x86_emulate_ctxt. This involves rearanging some fields. * Have x86_