Re: [Xen-devel] [PATCH v3] xentop: add support for qdisks

2015-03-31 Thread Ian Campbell
On Mon, 2015-03-30 at 16:20 +0100, Wei Liu wrote: > On Tue, Mar 24, 2015 at 04:59:47PM +, Ian Campbell wrote: > [...] > > > for running xentop in batch mode where the output can be captured. For > > > normal screen viewing, I doubt anyone has a screen with more that 1024 > > > lines on which to

Re: [Xen-devel] [PATCH v3] xentop: add support for qdisks

2015-03-30 Thread Wei Liu
On Tue, Mar 24, 2015 at 04:59:47PM +, Ian Campbell wrote: [...] > > for running xentop in batch mode where the output can be captured. For > > normal screen viewing, I doubt anyone has a screen with more that 1024 > > lines on which to view the output :) > > :-). I'm not sure if there is anyon

Re: [Xen-devel] [PATCH v3] xentop: add support for qdisks

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 10:24 -0600, Charles Arnold wrote: > >>> On 3/24/2015 at 09:01 AM, Ian Campbell wrote: > > On Mon, 2015-03-23 at 20:55 -0600, Charles Arnold wrote: > > > >> +/* Get up to 1024 active domains */ > > > > What I meant last time was, is this limitation a concern? What if there

Re: [Xen-devel] [PATCH v3] xentop: add support for qdisks

2015-03-24 Thread Charles Arnold
>>> On 3/24/2015 at 09:01 AM, Ian Campbell wrote: > On Mon, 2015-03-23 at 20:55 -0600, Charles Arnold wrote: > >> +/* Get up to 1024 active domains */ > > What I meant last time was, is this limitation a concern? What if there > are 1025 domains? This is actually a limit I picked up from libxl

Re: [Xen-devel] [PATCH v3] xentop: add support for qdisks

2015-03-24 Thread Ian Campbell
On Mon, 2015-03-23 at 20:55 -0600, Charles Arnold wrote: > +/* Get up to 1024 active domains */ What I meant last time was, is this limitation a concern? What if there are 1025 domains? If this is a concern then perhaps refactor such that the qdisk stats gathering collection can happen from the

[Xen-devel] [PATCH v3] xentop: add support for qdisks

2015-03-23 Thread Charles Arnold
Now that Xen uses qdisks by default and qemu does not write out statistics to sysfs this patch queries the QMP for disk statistics. This patch depends on libyajl for parsing statistics returned from QMP. The runtime requires libyajl 2.0.3 or newer for required bug fixes in yajl_tree_parse(). Libx