Re: [Xen-devel] [PATCH v3] xen: credit2: fix spinlock irq-safety violation

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 02:30:37AM +0200, Dario Faggioli wrote: > In commit ad4b3e1e9df34 ("xen: credit2: implement > utilization cap") xfree() was being called (for > deallocating the budget replenishment timer, during > domain destruction) inside an IRQ disabled critical > section. > > That must

Re: [Xen-devel] [PATCH v3] xen: credit2: fix spinlock irq-safety violation

2017-09-21 Thread George Dunlap
On 09/21/2017 01:30 AM, Dario Faggioli wrote: > In commit ad4b3e1e9df34 ("xen: credit2: implement > utilization cap") xfree() was being called (for > deallocating the budget replenishment timer, during > domain destruction) inside an IRQ disabled critical > section. > > That must not happen, as it

Re: [Xen-devel] [PATCH v3] xen: credit2: fix spinlock irq-safety violation

2017-09-21 Thread Roger Pau Monné
On Thu, Sep 21, 2017 at 02:30:37AM +0200, Dario Faggioli wrote: > In commit ad4b3e1e9df34 ("xen: credit2: implement > utilization cap") xfree() was being called (for > deallocating the budget replenishment timer, during > domain destruction) inside an IRQ disabled critical > section. > > That must

[Xen-devel] [PATCH v3] xen: credit2: fix spinlock irq-safety violation

2017-09-20 Thread Dario Faggioli
In commit ad4b3e1e9df34 ("xen: credit2: implement utilization cap") xfree() was being called (for deallocating the budget replenishment timer, during domain destruction) inside an IRQ disabled critical section. That must not happen, as it uses the mem-pool's lock, which needs to be taken with IRQ