>>> On 27.03.17 at 16:15, wrote:
> On Mon, Mar 27, 2017 at 02:58:15PM +0100, Andrew Cooper wrote:
>>
>> This needs to be inside a #ifdef CONFIG_SHADOW_PAGING to avoid breaking
>> the build.
>>
>
> I just found out there is a similar issue in x86/setup.c and I sent
> a separate patch to fix that
On Mon, Mar 27, 2017 at 02:58:15PM +0100, Andrew Cooper wrote:
>
> This needs to be inside a #ifdef CONFIG_SHADOW_PAGING to avoid breaking
> the build.
>
I just found out there is a similar issue in x86/setup.c and I sent
a separate patch to fix that.
Wei.
_
On 27/03/17 14:34, Wei Liu wrote:
> Classic PV shadow paging Dom0 has been broken for years, and can't
> possibly be configured after 4045953.
>
> PVH shadow paging Dom0 should still be possible.
>
> Change the code and documentation to clarify that.
>
> Signed-off-by: Wei Liu
> ---
> v3:
> 1. don
>>> On 27.03.17 at 15:36, wrote:
> On Mon, Mar 27, 2017 at 02:34:01PM +0100, Wei Liu wrote:
>>
>> +if ( opt_dom0_shadow && !dom0_pvh )
>> +{
>> +opt_dom0_shadow = false;
>> +printk("Shadow Dom0 requires PVH. Option ignored.");
>
> There should be a '\n' at the end.
With
On Mon, Mar 27, 2017 at 02:34:01PM +0100, Wei Liu wrote:
>
> +if ( opt_dom0_shadow && !dom0_pvh )
> +{
> +opt_dom0_shadow = false;
> +printk("Shadow Dom0 requires PVH. Option ignored.");
There should be a '\n' at the end.
Wei.
___
Classic PV shadow paging Dom0 has been broken for years, and can't
possibly be configured after 4045953.
PVH shadow paging Dom0 should still be possible.
Change the code and documentation to clarify that.
Signed-off-by: Wei Liu
---
v3:
1. don't panic
v2:
1. simplify need_paging
2. move panic t
