Re: [Xen-devel] [PATCH v3] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Jan > Beulich > Sent: 30 March 2016 15:23 > To: Paul Durrant > Cc: Andrew Cooper; Keir (Xen.org); xen-de...@lists.xenproject.org > Subject: Re: [Xen-devel] [PATCH v3] x86/h

Re: [Xen-devel] [PATCH v3] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Jan Beulich
>>> On 30.03.16 at 15:18, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 30 March 2016 14:15 >> To: Paul Durrant >> Cc: Andrew Cooper; xen-de...@lists.xenproject.org; Keir (Xen.org) >> Subject: Re: [PATCH v3] x86/hvm/viridian: zero and check vcpu con

Re: [Xen-devel] [PATCH v3] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 30 March 2016 14:15 > To: Paul Durrant > Cc: Andrew Cooper; xen-de...@lists.xenproject.org; Keir (Xen.org) > Subject: Re: [PATCH v3] x86/hvm/viridian: zero and check vcpu context > __pad field > > >>> On 30.03.16 a

Re: [Xen-devel] [PATCH v3] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Jan Beulich
>>> On 30.03.16 at 13:34, wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -589,7 +589,8 @@ static inline void guest_get_eff_kern_l1e(struct vcpu *v, > unsigned long addr, > TOGGLE_MODE(); > } > > -static const char __section(".bss.page_aligned.const") zero_page[PAGE_SIZE];

[Xen-devel] [PATCH v3] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Paul Durrant
Commit 57844631 "save APIC assist vector" added an extra field to the viridian vcpu context save record. This field was only a uint8_t and so an extra __pad field was also added to pad up to the next 64-bit boundary. This patch makes sure that __pad field is zeroed on save and checked for zero on