Re: [Xen-devel] [PATCH v3] vsprintf: Make sure argument to %pX specifier is valid

2015-02-18 Thread Jan Beulich
>>> On 18.02.15 at 16:39, wrote: > --- a/xen/common/vsprintf.c > +++ b/xen/common/vsprintf.c > @@ -269,7 +269,28 @@ static char *pointer(char *str, char *end, const char > **fmt_ptr, > { > const char *fmt = *fmt_ptr, *s; > > -/* Custom %p suffixes. See XEN_ROOT/docs/misc/printk-format

Re: [Xen-devel] [PATCH v3] vsprintf: Make sure argument to %pX specifier is valid

2015-02-18 Thread Boris Ostrovsky
On 02/18/2015 10:52 AM, Julien Grall wrote: Hi Boris, On 18/02/2015 15:39, Boris Ostrovsky wrote: If invalid pointer (i.e. something smaller than HYPERVISOR_VIRT_START) is passed for %*ph/%pv/%ps/%pS format specifiers then print value of the pointer in parentheses. For example: struct vcpu

Re: [Xen-devel] [PATCH v3] vsprintf: Make sure argument to %pX specifier is valid

2015-02-18 Thread Julien Grall
Hi Boris, On 18/02/2015 15:39, Boris Ostrovsky wrote: If invalid pointer (i.e. something smaller than HYPERVISOR_VIRT_START) is passed for %*ph/%pv/%ps/%pS format specifiers then print value of the pointer in parentheses. For example: struct vcpu *v0 = NULL; struct vcpu *v1 = (void *)0xffU

Re: [Xen-devel] [PATCH v3] vsprintf: Make sure argument to %pX specifier is valid

2015-02-18 Thread Andrew Cooper
On 18/02/15 15:39, Boris Ostrovsky wrote: > If invalid pointer (i.e. something smaller than HYPERVISOR_VIRT_START) > is passed for %*ph/%pv/%ps/%pS format specifiers then print value of the > pointer in parentheses. > > For example: > > struct vcpu *v0 = NULL; > struct vcpu *v1 = (void *)0xffUL;

[Xen-devel] [PATCH v3] vsprintf: Make sure argument to %pX specifier is valid

2015-02-18 Thread Boris Ostrovsky
If invalid pointer (i.e. something smaller than HYPERVISOR_VIRT_START) is passed for %*ph/%pv/%ps/%pS format specifiers then print value of the pointer in parentheses. For example: struct vcpu *v0 = NULL; struct vcpu *v1 = (void *)0xffUL; unsigned val = 0xab; unsigned *ptr = &val; unsigned *