Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-09-05 Thread Stefano Stabellini
On Wed, 3 Aug 2016, Tamas K Lengyel wrote: > The two functions monitor_traps and mem_access_send_req duplicate some of the > same functionality. The mem_access_send_req however leaves a lot of the > standard vm_event fields to be filled by other functions. > > Remove mem_access_send_req() complete

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-09-02 Thread Tamas K Lengyel
On Wed, Aug 3, 2016 at 12:41 PM, Tamas K Lengyel wrote: > The two functions monitor_traps and mem_access_send_req duplicate some of the > same functionality. The mem_access_send_req however leaves a lot of the > standard vm_event fields to be filled by other functions. > > Remove mem_access_send_r

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 18:16, wrote: > On Thu, Aug 4, 2016 at 1:51 AM, Jan Beulich wrote: > On 04.08.16 at 08:36, wrote: >>> On Thu, Aug 4, 2016 at 12:29 AM, Jan Beulich wrote: >>> On 03.08.16 at 20:41, wrote: > @@ -1846,11 +1846,15 @@ int hvm_hap_nested_page_fault(paddr_t gpa, >

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-04 Thread Tamas K Lengyel
On Thu, Aug 4, 2016 at 1:51 AM, Jan Beulich wrote: On 04.08.16 at 08:36, wrote: >> On Thu, Aug 4, 2016 at 12:29 AM, Jan Beulich wrote: >> On 03.08.16 at 20:41, wrote: @@ -1846,11 +1846,15 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla,

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-04 Thread George Dunlap
On 04/08/16 10:36, Jan Beulich wrote: On 04.08.16 at 11:25, wrote: >> On 04/08/16 08:51, Jan Beulich wrote: >> On 04.08.16 at 08:36, wrote: On Thu, Aug 4, 2016 at 12:29 AM, Jan Beulich wrote: On 03.08.16 at 20:41, wrote: >> @@ -1846,11 +1846,15 @@ int hvm_hap_nested_p

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 11:25, wrote: > On 04/08/16 08:51, Jan Beulich wrote: > On 04.08.16 at 08:36, wrote: >>> On Thu, Aug 4, 2016 at 12:29 AM, Jan Beulich wrote: >>> On 03.08.16 at 20:41, wrote: > @@ -1846,11 +1846,15 @@ int hvm_hap_nested_page_fault(paddr_t gpa, > unsigned > lo

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-04 Thread George Dunlap
On 04/08/16 08:51, Jan Beulich wrote: On 04.08.16 at 08:36, wrote: >> On Thu, Aug 4, 2016 at 12:29 AM, Jan Beulich wrote: >> On 03.08.16 at 20:41, wrote: @@ -1846,11 +1846,15 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla, }

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 08:36, wrote: > On Thu, Aug 4, 2016 at 12:29 AM, Jan Beulich wrote: > On 03.08.16 at 20:41, wrote: >>> @@ -1846,11 +1846,15 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned >>> long gla, >>> } >>> } >>> >>> -if ( p2m_mem_acc

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-03 Thread Tamas K Lengyel
On Thu, Aug 4, 2016 at 12:29 AM, Jan Beulich wrote: On 03.08.16 at 20:41, wrote: >> The two functions monitor_traps and mem_access_send_req duplicate some of the >> same functionality. The mem_access_send_req however leaves a lot of the >> standard vm_event fields to be filled by other funct

Re: [Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-03 Thread Jan Beulich
>>> On 03.08.16 at 20:41, wrote: > The two functions monitor_traps and mem_access_send_req duplicate some of the > same functionality. The mem_access_send_req however leaves a lot of the > standard vm_event fields to be filled by other functions. > > Remove mem_access_send_req() completely, makin

[Xen-devel] [PATCH v3] mem_access: sanitize code around sending vm_event request

2016-08-03 Thread Tamas K Lengyel
The two functions monitor_traps and mem_access_send_req duplicate some of the same functionality. The mem_access_send_req however leaves a lot of the standard vm_event fields to be filled by other functions. Remove mem_access_send_req() completely, making use of monitor_traps() to put requests int