Re: [Xen-devel] [PATCH v3] hvm: fix hypervisor crash in hvm_save_one()

2017-05-03 Thread Andrew Cooper
On 03/05/17 13:45, Razvan Cojocaru wrote: > On 05/03/17 15:22, Jan Beulich wrote: >> hvm_save_cpu_ctxt() returns success without writing any data into >> hvm_domain_context_t when all VCPUs are offline. This can then crash >> the hypervisor (with FATAL PAGE FAULT) in hvm_save_one() via the >> "off

Re: [Xen-devel] [PATCH v3] hvm: fix hypervisor crash in hvm_save_one()

2017-05-03 Thread Razvan Cojocaru
On 05/03/17 15:22, Jan Beulich wrote: > hvm_save_cpu_ctxt() returns success without writing any data into > hvm_domain_context_t when all VCPUs are offline. This can then crash > the hypervisor (with FATAL PAGE FAULT) in hvm_save_one() via the > "off < (ctxt.cur - sizeof(*desc))" for() test, where

[Xen-devel] [PATCH v3] hvm: fix hypervisor crash in hvm_save_one()

2017-05-03 Thread Jan Beulich
hvm_save_cpu_ctxt() returns success without writing any data into hvm_domain_context_t when all VCPUs are offline. This can then crash the hypervisor (with FATAL PAGE FAULT) in hvm_save_one() via the "off < (ctxt.cur - sizeof(*desc))" for() test, where ctxt.cur remains 0, causing an underflow which