Re: [Xen-devel] [PATCH v3] dom variable error handled in Xenstore

2015-11-02 Thread Ian Campbell
On Fri, 2015-10-30 at 15:28 +0100, Dario Faggioli wrote: > On Thu, 2015-10-29 at 20:28 +0530, Lasya Venneti wrote: > > > > > > On 29 October 2015 at 15:41, Dario Faggioli < > > dario.faggi...@citrix.com> wrote: > > > On Thu, 2015-10-29 at 10:07 +, Wei Liu wrote: > > > > > As for xc_dom_alloc

Re: [Xen-devel] [PATCH v3] dom variable error handled in Xenstore

2015-10-30 Thread Dario Faggioli
On Thu, 2015-10-29 at 20:28 +0530, Lasya Venneti wrote: > > > On 29 October 2015 at 15:41, Dario Faggioli < > dario.faggi...@citrix.com> wrote: > > On Thu, 2015-10-29 at 10:07 +, Wei Liu wrote: > > > As for xc_dom_allocate, the only failure path at the moment is > > malloc > > > failure, whi

Re: [Xen-devel] [PATCH v3] dom variable error handled in Xenstore

2015-10-29 Thread Lasya Venneti
On 29 October 2015 at 15:41, Dario Faggioli wrote: > On Thu, 2015-10-29 at 10:07 +, Wei Liu wrote: > > On Thu, Oct 29, 2015 at 12:42:18AM +0530, Lasya Venneti wrote: > > > > I must also add errno.h header to the file, I forgot to do that. I > > > shall > > > do so in the next version. > > > >

Re: [Xen-devel] [PATCH v3] dom variable error handled in Xenstore

2015-10-29 Thread Dario Faggioli
On Thu, 2015-10-29 at 10:07 +, Wei Liu wrote: > On Thu, Oct 29, 2015 at 12:42:18AM +0530, Lasya Venneti wrote: > > I must also add errno.h header to the file, I forgot to do that. I > > shall > > do so in the next version. > > > > Other xc functions that issue hypercall (that is, you can tra

Re: [Xen-devel] [PATCH v3] dom variable error handled in Xenstore

2015-10-29 Thread Dario Faggioli
On Thu, 2015-10-29 at 00:42 +0530, Lasya Venneti wrote: > > On 28 October 2015 at 06:30, Dario Faggioli < > dario.faggi...@citrix.com> wrote: > > > diff --git a/tools/xenstore/init-xenstore-domain.c > > > @@ -42,6 +42,10 @@ static int build(xc_interface *xch, int argc, > > > char** argv) > > >

Re: [Xen-devel] [PATCH v3] dom variable error handled in Xenstore

2015-10-29 Thread Wei Liu
On Thu, Oct 29, 2015 at 12:42:18AM +0530, Lasya Venneti wrote: > On 28 October 2015 at 06:30, Dario Faggioli > wrote: > > > On Wed, 2015-10-28 at 05:42 +0530, Lasya wrote: > > > xc_dom_allocate function in build function in init-xenstore-domain.c > > > returns NULL on failure. > > > In that case,

Re: [Xen-devel] [PATCH v3] dom variable error handled in Xenstore

2015-10-28 Thread Lasya Venneti
On 28 October 2015 at 06:30, Dario Faggioli wrote: > On Wed, 2015-10-28 at 05:42 +0530, Lasya wrote: > > xc_dom_allocate function in build function in init-xenstore-domain.c > > returns NULL on failure. > > In that case, variable rv is set to ENOMEM and directed to failure > > path err. > > > > >

Re: [Xen-devel] [PATCH v3] dom variable error handled in Xenstore

2015-10-27 Thread Dario Faggioli
On Wed, 2015-10-28 at 05:42 +0530, Lasya wrote: > xc_dom_allocate function in build function in init-xenstore-domain.c > returns NULL on failure. > In that case, variable rv is set to ENOMEM and directed to failure > path err. > > So, about the subject line: - we want tags (as in "tag: does s

[Xen-devel] [PATCH v3] dom variable error handled in Xenstore

2015-10-27 Thread Lasya
xc_dom_allocate function in build function in init-xenstore-domain.c returns NULL on failure. In that case, variable rv is set to ENOMEM and directed to failure path err. Signed-off-by: Lasya Venneti --- tools/xenstore/init-xenstore-domain.c | 4 1 file changed, 4 insertions(+) diff -