Re: [Xen-devel] [PATCH v2 8/9] xen: arm: handle remaining traps from userspace

2015-02-19 Thread Ian Campbell
On Tue, 2015-02-17 at 15:28 +, Julien Grall wrote: > Hi Ian, > > On 10/02/15 04:45, Ian Campbell wrote: > > case HSR_EC_SMC64: > > +BUG_ON(psr_mode_is_32bit(regs->cpsr)); > > perfc_incr(trap_smc64); > > -inject_undef64_exception(regs, hsr.len); > > I don't unders

Re: [Xen-devel] [PATCH v2 8/9] xen: arm: handle remaining traps from userspace

2015-02-17 Thread Julien Grall
Hi Ian, On 10/02/15 04:45, Ian Campbell wrote: > case HSR_EC_SMC64: > +BUG_ON(psr_mode_is_32bit(regs->cpsr)); > perfc_incr(trap_smc64); > -inject_undef64_exception(regs, hsr.len); I don't understand why you drop the #undef injection. Is it a mistake? Regards, -- J

[Xen-devel] [PATCH v2 8/9] xen: arm: handle remaining traps from userspace

2015-02-09 Thread Ian Campbell
CP14 dbg and general CP register access are both handled with unconditional injection of #undef from their respective handlers, so allow these even from 32-bit userspace on a 64-bit kernel. SMC32 and HVC32 should only come from a guest in AArch32 mode and SMC64 and HVC64 should only come from a gu