Re: [Xen-devel] [PATCH v2 6/8] xenalyze: handle more events in sched_process

2015-05-12 Thread Dario Faggioli
On Thu, 2015-05-07 at 18:42 +0100, George Dunlap wrote: > On Thu, May 7, 2015 at 6:28 PM, Andrew Cooper > wrote: > > Is it a candidate for dropping from the hypervisor then? No use keeping > > useless tracepoints. > > Well it would have to be replaced with something more informative. > Indeed.

Re: [Xen-devel] [PATCH v2 6/8] xenalyze: handle more events in sched_process

2015-05-07 Thread Olaf Hering
On Fri, May 08, Wei Liu wrote: > On Thu, May 07, 2015 at 10:35:42AM +, Olaf Hering wrote: > > +void sched_class(struct record_info *ri) > > +{ > > +} > Huh, this does nothing? Is it because this is only a stub (you haven't > got around to implement it) or it is supposed to be like this? Whate

Re: [Xen-devel] [PATCH v2 6/8] xenalyze: handle more events in sched_process

2015-05-07 Thread Wei Liu
On Thu, May 07, 2015 at 10:35:42AM +, Olaf Hering wrote: > Signed-off-by: Olaf Hering > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Ian Campbell > Cc: Wei Liu > --- > tools/xentrace/xenalyze/xenalyze.c | 73 > ++ > 1 file changed, 66 insertions(+),

Re: [Xen-devel] [PATCH v2 6/8] xenalyze: handle more events in sched_process

2015-05-07 Thread George Dunlap
On Thu, May 7, 2015 at 6:28 PM, Andrew Cooper wrote: > On 07/05/15 18:13, George Dunlap wrote: >>> +case TRC_SCHED_ADJDOM: >>> > +printf(" %s sched_adjdom domid d%u\n", >>> > + ri->dump_header, ri->d[0]); >>> > +break; >> Wow, this has got to be on

Re: [Xen-devel] [PATCH v2 6/8] xenalyze: handle more events in sched_process

2015-05-07 Thread Andrew Cooper
On 07/05/15 18:13, George Dunlap wrote: >> +case TRC_SCHED_ADJDOM: >> > +printf(" %s sched_adjdom domid d%u\n", >> > + ri->dump_header, ri->d[0]); >> > +break; > Wow, this has got to be one of the most useless trace points > ever... > Is it a candi

Re: [Xen-devel] [PATCH v2 6/8] xenalyze: handle more events in sched_process

2015-05-07 Thread George Dunlap
On Thu, May 7, 2015 at 11:35 AM, Olaf Hering wrote: > Signed-off-by: Olaf Hering > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Ian Campbell > Cc: Wei Liu [snip] > +case TRC_SCHED_ADJDOM: > +printf(" %s sched_adjdom domid d%u\n", > + ri->dump_header,

[Xen-devel] [PATCH v2 6/8] xenalyze: handle more events in sched_process

2015-05-07 Thread Olaf Hering
Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/xentrace/xenalyze/xenalyze.c | 73 ++ 1 file changed, 66 insertions(+), 7 deletions(-) diff --git a/tools/xentrace/xenalyze/xenalyze.c b/tools/xentrac