Re: [Xen-devel] [PATCH v2 5/9] xen: arm: Handle CP15 register traps from userspace

2015-02-19 Thread Ian Campbell
On Thu, 2015-02-19 at 14:53 +, Julien Grall wrote: > On 19/02/15 12:15, Ian Campbell wrote: > > On Tue, 2015-02-17 at 15:07 +, Julien Grall wrote: > >> Hi Ian, > >> > >> On 10/02/15 04:45, Ian Campbell wrote: > >>> default: > >>> @@ -2047,8 +2070,7 @@ asmlinkage void do_trap_hypervisor

Re: [Xen-devel] [PATCH v2 5/9] xen: arm: Handle CP15 register traps from userspace

2015-02-19 Thread Julien Grall
On 19/02/15 12:15, Ian Campbell wrote: > On Tue, 2015-02-17 at 15:07 +, Julien Grall wrote: >> Hi Ian, >> >> On 10/02/15 04:45, Ian Campbell wrote: >>> default: >>> @@ -2047,8 +2070,7 @@ asmlinkage void do_trap_hypervisor(struct >>> cpu_user_regs *regs) >>> advance_pc(regs, hsr);

Re: [Xen-devel] [PATCH v2 5/9] xen: arm: Handle CP15 register traps from userspace

2015-02-19 Thread Ian Campbell
On Tue, 2015-02-17 at 15:07 +, Julien Grall wrote: > Hi Ian, > > On 10/02/15 04:45, Ian Campbell wrote: > > default: > > @@ -2047,8 +2070,7 @@ asmlinkage void do_trap_hypervisor(struct > > cpu_user_regs *regs) > > advance_pc(regs, hsr); > > break; > > case HSR_EC_C

Re: [Xen-devel] [PATCH v2 5/9] xen: arm: Handle CP15 register traps from userspace

2015-02-17 Thread Julien Grall
Hi Ian, On 10/02/15 04:45, Ian Campbell wrote: > default: > @@ -2047,8 +2070,7 @@ asmlinkage void do_trap_hypervisor(struct cpu_user_regs > *regs) > advance_pc(regs, hsr); > break; > case HSR_EC_CP15_32: > -if ( !is_32bit_domain(current->domain) ) > -

[Xen-devel] [PATCH v2 5/9] xen: arm: Handle CP15 register traps from userspace

2015-02-09 Thread Ian Campbell
Previously userspace access to PM* would have been incorrectly (but benignly) implemented as RAZ/WI when running on a 32-bit kernel and would cause a hypervisor exception (host crash) when running a 64-bit kernel (this was already solved via the fix to XSA-102). CLIDR, CCSIDR, DCCISW, ACTLR, PMINT