Re: [Xen-devel] [PATCH v2 4/9] xen: arm: correctly handle vtimer traps from userspace

2015-02-25 Thread Julien Grall
On 25/02/15 14:32, Ian Campbell wrote: > On Thu, 2015-02-19 at 15:13 +, Ian Campbell wrote: >> On Thu, 2015-02-19 at 14:42 +, Julien Grall wrote: > Although, I think the debug message in bad_trap is useful to keep. It > may be handy to have the HSR and the guest stack trace printed

Re: [Xen-devel] [PATCH v2 4/9] xen: arm: correctly handle vtimer traps from userspace

2015-02-25 Thread Ian Campbell
On Thu, 2015-02-19 at 15:13 +, Ian Campbell wrote: > On Thu, 2015-02-19 at 14:42 +, Julien Grall wrote: > > >> Although, I think the debug message in bad_trap is useful to keep. It > > >> may be handy to have the HSR and the guest stack trace printed if Xen > > >> hit the condition. > > >

Re: [Xen-devel] [PATCH v2 4/9] xen: arm: correctly handle vtimer traps from userspace

2015-02-19 Thread Ian Campbell
On Thu, 2015-02-19 at 14:42 +, Julien Grall wrote: > >> > >> [..] > >> > >>> @@ -2062,8 +2053,7 @@ asmlinkage void do_trap_hypervisor(struct > >>> cpu_user_regs *regs) > >>> do_cp15_32(regs, hsr); > >>> break; > >>> case HSR_EC_CP15_64: > >>> -if ( !is_32bit_d

Re: [Xen-devel] [PATCH v2 4/9] xen: arm: correctly handle vtimer traps from userspace

2015-02-19 Thread Julien Grall
On 19/02/15 12:10, Ian Campbell wrote: > On Tue, 2015-02-10 at 14:41 +0800, Julien Grall wrote: >> Hi Ian, >> >> On 10/02/2015 12:45, Ian Campbell wrote: >>> Previously 32-bit userspace on 32-bit kernel and 64-bit userspace on 64-bit >>> kernel could access these registers irrespective of whether t

Re: [Xen-devel] [PATCH v2 4/9] xen: arm: correctly handle vtimer traps from userspace

2015-02-19 Thread Ian Campbell
On Tue, 2015-02-10 at 14:41 +0800, Julien Grall wrote: > Hi Ian, > > On 10/02/2015 12:45, Ian Campbell wrote: > > Previously 32-bit userspace on 32-bit kernel and 64-bit userspace on 64-bit > > kernel could access these registers irrespective of whether the kernel had > > configured them to be all

Re: [Xen-devel] [PATCH v2 4/9] xen: arm: correctly handle vtimer traps from userspace

2015-02-09 Thread Julien Grall
Hi Ian, On 10/02/2015 12:45, Ian Campbell wrote: Previously 32-bit userspace on 32-bit kernel and 64-bit userspace on 64-bit kernel could access these registers irrespective of whether the kernel had configured them to be allowed to. To fix this: - Userspace access to CNTP_CTL_EL0 and CNTP_TV

[Xen-devel] [PATCH v2 4/9] xen: arm: correctly handle vtimer traps from userspace

2015-02-09 Thread Ian Campbell
Previously 32-bit userspace on 32-bit kernel and 64-bit userspace on 64-bit kernel could access these registers irrespective of whether the kernel had configured them to be allowed to. To fix this: - Userspace access to CNTP_CTL_EL0 and CNTP_TVAL_EL0 should be gated on CNTKCTL_EL1.EL0PTEN. -