Re: [Xen-devel] [PATCH v2 4/6] tools/libxl: move remus code into libxl_remus.c

2015-06-16 Thread Yang Hongyang
On 06/16/2015 09:08 PM, Ian Campbell wrote: On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote: move remus code into libxl_remus.c. Please say something like "... by refactoring bits of libxl_domain_remus_start and domain_save_done into X and Y and moving the remaining functionality unch

Re: [Xen-devel] [PATCH v2 4/6] tools/libxl: move remus code into libxl_remus.c

2015-06-16 Thread Ian Campbell
On Wed, 2015-06-03 at 16:01 +0800, Yang Hongyang wrote: > move remus code into libxl_remus.c. Please say something like "... by refactoring bits of libxl_domain_remus_start and domain_save_done into X and Y and moving the remaining functionality unchanged into the new file". I gave two examples o

[Xen-devel] [PATCH v2 4/6] tools/libxl: move remus code into libxl_remus.c

2015-06-03 Thread Yang Hongyang
move remus code into libxl_remus.c. Signed-off-by: Yang Hongyang CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.c | 55 +--- tools/libxl/libxl_dom.c | 206 + tools/libxl/libxl_internal.h