Re: [Xen-devel] [PATCH v2 29/30] tools/libxc: Use featuresets rather than guesswork

2016-02-17 Thread Jan Beulich
>>> On 17.02.16 at 14:03, wrote: > On 17/02/16 08:55, Jan Beulich wrote: > On 05.02.16 at 14:42, wrote: >>> @@ -467,11 +420,8 @@ static void xc_cpuid_config_xsave(xc_interface *xch, >>> regs[1] = 512 + 64; /* FP/SSE + XSAVE.HEADER */ >>> break; >>> case 1: /* leaf 1 */

Re: [Xen-devel] [PATCH v2 29/30] tools/libxc: Use featuresets rather than guesswork

2016-02-17 Thread Andrew Cooper
On 17/02/16 08:55, Jan Beulich wrote: On 05.02.16 at 14:42, wrote: >> @@ -467,11 +420,8 @@ static void xc_cpuid_config_xsave(xc_interface *xch, >> regs[1] = 512 + 64; /* FP/SSE + XSAVE.HEADER */ >> break; >> case 1: /* leaf 1 */ >> -regs[0] &= (XSAVEOPT | XSAVEC

Re: [Xen-devel] [PATCH v2 29/30] tools/libxc: Use featuresets rather than guesswork

2016-02-17 Thread Jan Beulich
>>> On 05.02.16 at 14:42, wrote: > @@ -467,11 +420,8 @@ static void xc_cpuid_config_xsave(xc_interface *xch, > regs[1] = 512 + 64; /* FP/SSE + XSAVE.HEADER */ > break; > case 1: /* leaf 1 */ > -regs[0] &= (XSAVEOPT | XSAVEC | XGETBV1 | XSAVES); > -if ( !info-

Re: [Xen-devel] [PATCH v2 29/30] tools/libxc: Use featuresets rather than guesswork

2016-02-05 Thread Wei Liu
On Fri, Feb 05, 2016 at 01:42:22PM +, Andrew Cooper wrote: > It is conceptually wrong to base a VM's featureset on the features visible to > the toolstack which happens to construct it. > Agreed. > Instead, the featureset used is either an explicit one passed by the > toolstack, or the defau

[Xen-devel] [PATCH v2 29/30] tools/libxc: Use featuresets rather than guesswork

2016-02-05 Thread Andrew Cooper
It is conceptually wrong to base a VM's featureset on the features visible to the toolstack which happens to construct it. Instead, the featureset used is either an explicit one passed by the toolstack, or the default which Xen believes it can give to the guest. Collect all the feature manipulati