Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-09-23 Thread Jan Beulich
>>> On 22.09.15 at 19:03, wrote: > On Thu, Aug 27, 2015 at 06:43:39AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:29, wrote: >> > +#define __packed __attribute__((__packed__)) >> > +#define __text__attribute__((__section__(".text"))) >> > +#define __used__attribute

Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-09-22 Thread Daniel Kiper
On Thu, Aug 27, 2015 at 06:43:39AM -0600, Jan Beulich wrote: > >>> On 20.07.15 at 16:29, wrote: > > Current early command line parser implementation in assembler > > is very difficult to change to relocatable stuff using segment > > registers. This requires a lot of changes in very weird and > > f

Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-27 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > Current early command line parser implementation in assembler > is very difficult to change to relocatable stuff using segment > registers. This requires a lot of changes in very weird and > fragile code. So, reimplement this functionality in C. This > way code w

Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-17 Thread Daniel Kiper
On Sun, Aug 16, 2015 at 01:22:05PM -0400, Konrad Rzeszutek Wilk wrote: > On August 16, 2015 9:48:05 AM EDT, George Diamantopoulos > wrote: > >Hello, > > > >I've been trying to compile xen with multiboot2 support, but building > >has > >been failing. Tried with both gcc-4.8.4 and gcc-5.2 on ivybri

Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-16 Thread Konrad Rzeszutek Wilk
On August 16, 2015 9:48:05 AM EDT, George Diamantopoulos wrote: >Hello, > >I've been trying to compile xen with multiboot2 support, but building >has >been failing. Tried with both gcc-4.8.4 and gcc-5.2 on ivybridge and >amdfam10h, same results. > CCing Daniel who has been troubleshooting that.

Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-16 Thread George Diamantopoulos
Hello, I've been trying to compile xen with multiboot2 support, but building has been failing. Tried with both gcc-4.8.4 and gcc-5.2 on ivybridge and amdfam10h, same results. The error I'm getting is: Error: non-empty .rodata: 0x090 build32.mk:22: recipe for target 'cmdline.o' failed Cummulativ

Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-11 Thread Konrad Rzeszutek Wilk
> +static void vga_parse(const char *cmdline, early_boot_opts_t *ebo) > +{ > +const char *c; > +int tmp; > +size_t la; > +static const char empty_chars_comma[] __text = " \n\r\t,"; > +static const char x[] __text = "x"; > +static const char vga[] __text = "vga="; > +stat

Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:16PM +0200, Daniel Kiper wrote: > Current early command line parser implementation in assembler > is very difficult to change to relocatable stuff using segment > registers. This requires a lot of changes in very weird and > fragile code. So, reimplement this functiona

[Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-07-20 Thread Daniel Kiper
Current early command line parser implementation in assembler is very difficult to change to relocatable stuff using segment registers. This requires a lot of changes in very weird and fragile code. So, reimplement this functionality in C. This way code will be relocatable out of the box and much e