Re: [Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-23 Thread Oleksandr Tyshchenko
Hi, Julien. I created a new patch set (v3) and pushed. Also I created a standalone patch according to your suggestion above: http://lists.xen.org/archives/html/xen-devel/2015-01/msg02964.html I checked it on Lager board on current master. On Thu, Jan 22, 2015 at 8:33 PM, Oleksandr Tyshchenko <

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-22 Thread Oleksandr Tyshchenko
On Thu, Jan 22, 2015 at 8:09 PM, Julien Grall wrote: > On 22/01/15 17:43, Oleksandr Tyshchenko wrote: >> On Thu, Jan 22, 2015 at 7:27 PM, Oleksandr Tyshchenko >> wrote: >>> On Thu, Jan 22, 2015 at 7:02 PM, Julien Grall >>> wrote: On 22/01/15 16:55, Oleksandr Tyshchenko wrote: > On Thu,

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-22 Thread Julien Grall
On 22/01/15 17:43, Oleksandr Tyshchenko wrote: > On Thu, Jan 22, 2015 at 7:27 PM, Oleksandr Tyshchenko > wrote: >> On Thu, Jan 22, 2015 at 7:02 PM, Julien Grall >> wrote: >>> On 22/01/15 16:55, Oleksandr Tyshchenko wrote: On Thu, Jan 22, 2015 at 6:49 PM, Julien Grall wrote: > On

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-22 Thread Oleksandr Tyshchenko
On Thu, Jan 22, 2015 at 7:27 PM, Oleksandr Tyshchenko wrote: > On Thu, Jan 22, 2015 at 7:02 PM, Julien Grall wrote: >> On 22/01/15 16:55, Oleksandr Tyshchenko wrote: >>> On Thu, Jan 22, 2015 at 6:49 PM, Julien Grall >>> wrote: On 22/01/15 16:44, Oleksandr Tyshchenko wrote: > I understa

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-22 Thread Oleksandr Tyshchenko
On Thu, Jan 22, 2015 at 7:02 PM, Julien Grall wrote: > On 22/01/15 16:55, Oleksandr Tyshchenko wrote: >> On Thu, Jan 22, 2015 at 6:49 PM, Julien Grall >> wrote: >>> On 22/01/15 16:44, Oleksandr Tyshchenko wrote: I understand, then I will implement local delay func in uart driver based

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-22 Thread Julien Grall
On 22/01/15 16:55, Oleksandr Tyshchenko wrote: > On Thu, Jan 22, 2015 at 6:49 PM, Julien Grall wrote: >> On 22/01/15 16:44, Oleksandr Tyshchenko wrote: >>> I understand, then I will implement local delay func in uart driver >>> based on READ_SYSREG64(CNTPCT_EL0). >> >> Unless I miss something, ude

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-22 Thread Oleksandr Tyshchenko
On Thu, Jan 22, 2015 at 6:49 PM, Julien Grall wrote: > On 22/01/15 16:44, Oleksandr Tyshchenko wrote: >> I understand, then I will implement local delay func in uart driver >> based on READ_SYSREG64(CNTPCT_EL0). > > Unless I miss something, udelay should work in your case even if the > xen_init_ti

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-22 Thread Julien Grall
On 22/01/15 16:44, Oleksandr Tyshchenko wrote: > I understand, then I will implement local delay func in uart driver > based on READ_SYSREG64(CNTPCT_EL0). Unless I miss something, udelay should work in your case even if the xen_init_time is not called. Regards, -- Julien Grall

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-22 Thread Oleksandr Tyshchenko
On Thu, Jan 22, 2015 at 6:18 PM, Julien Grall wrote: > On 22/01/15 16:04, Oleksandr Tyshchenko wrote: >> >> >> On Thu, Jan 22, 2015 at 4:44 PM, Julien Grall > > wrote: > >> Hi Julien, > > Hi Oleksandr, > >>> >>> On 21/01/15 14:16, Iurii Konovalenko wrote: >>> > diff

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-22 Thread Julien Grall
On 22/01/15 16:04, Oleksandr Tyshchenko wrote: > > > On Thu, Jan 22, 2015 at 4:44 PM, Julien Grall > wrote: > Hi Julien, Hi Oleksandr, >> >> On 21/01/15 14:16, Iurii Konovalenko wrote: >> > diff --git a/xen/drivers/char/rcar2-uart.c > b/xen/drivers/char/rcar2-u

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-22 Thread Oleksandr Tyshchenko
On Thu, Jan 22, 2015 at 4:44 PM, Julien Grall wrote: > > Hi Iurii, Hi Julien, It's Oleksandr. Thank you for your comments. > > > On 21/01/15 14:16, Iurii Konovalenko wrote: > > diff --git a/xen/drivers/char/rcar2-uart.c b/xen/drivers/char/rcar2-uart.c > > +static void rcar2_uart_interrupt(int ir

Re: [Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-22 Thread Julien Grall
Hi Iurii, On 21/01/15 14:16, Iurii Konovalenko wrote: > diff --git a/xen/drivers/char/rcar2-uart.c b/xen/drivers/char/rcar2-uart.c > +static void rcar2_uart_interrupt(int irq, void *data, struct cpu_user_regs > *regs) > +{ > +struct serial_port *port = data; > +struct rcar2_uart *uart = p

[Xen-devel] [PATCH v2 2/3] xen/arm: Add new driver for R-Car Gen2 UART

2015-01-21 Thread Iurii Konovalenko
From: Oleksandr Tyshchenko Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Iurii Konovalenko --- config/arm32.mk | 1 + xen/drivers/char/Makefile | 1 + xen/drivers/char/rcar2-uart.c | 376 ++ 3 files changed, 378 insertions(+)