Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config"): > On Tue, Jun 14, 2016 at 11:58:58AM +0100, Anthony PERARD wrote: > > I did: > > LD_LIBRARY_PATH=`pwd` ./xl -vvv migrate arch localhost > > Never tried this so I'm not sure what might go wrong... That is

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Anthony PERARD
On Tue, Jun 14, 2016 at 11:58:58AM +0100, Anthony PERARD wrote: > On Tue, Jun 14, 2016 at 11:50:12AM +0100, Wei Liu wrote: > > On Tue, Jun 14, 2016 at 11:47:57AM +0100, Anthony PERARD wrote: > > [...] > > > > > > + > > > > > > int libxl_retrieve_domain_configuration(libxl_ctx *ctx, uint32_t > > >

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 11:58:58AM +0100, Anthony PERARD wrote: [...] > > > > This means your device model version is LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN > > so it should be covered by the correct case. > > > > I'm confused. > > If it works for you, I'll properly install Xen with your patch in,

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Anthony PERARD
On Tue, Jun 14, 2016 at 11:50:12AM +0100, Wei Liu wrote: > On Tue, Jun 14, 2016 at 11:47:57AM +0100, Anthony PERARD wrote: > [...] > > > > > + > > > > > int libxl_retrieve_domain_configuration(libxl_ctx *ctx, uint32_t > > > > > domid, > > > > > libxl_domai

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 11:47:57AM +0100, Anthony PERARD wrote: [...] > > > > + > > > > int libxl_retrieve_domain_configuration(libxl_ctx *ctx, uint32_t domid, > > > > libxl_domain_config *d_config) > > > > { > > > > @@ -7270,6 +7317,46 @@ int > > > > lib

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Anthony PERARD
On Mon, Jun 13, 2016 at 07:21:53PM +0100, Wei Liu wrote: > On Mon, Jun 13, 2016 at 06:39:36PM +0100, Anthony PERARD wrote: > > On Wed, Jun 08, 2016 at 03:28:45PM +0100, Wei Liu wrote: > > > ... because the available vcpu bitmap can change during domain life time > > > due to cpu hotplug and unplug.

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-13 Thread Wei Liu
On Mon, Jun 13, 2016 at 06:39:36PM +0100, Anthony PERARD wrote: > On Wed, Jun 08, 2016 at 03:28:45PM +0100, Wei Liu wrote: > > ... because the available vcpu bitmap can change during domain life time > > due to cpu hotplug and unplug. > > > > For QEMU upstream, we interrogate QEMU for the number o

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-13 Thread Anthony PERARD
On Wed, Jun 08, 2016 at 03:28:45PM +0100, Wei Liu wrote: > ... because the available vcpu bitmap can change during domain life time > due to cpu hotplug and unplug. > > For QEMU upstream, we interrogate QEMU for the number of vcpus. For > others, we look directly into xenstore for information. I

Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-08 Thread Dario Faggioli
On Wed, 2016-06-08 at 15:28 +0100, Wei Liu wrote: > ... because the available vcpu bitmap can change during domain life > time > due to cpu hotplug and unplug. > > For QEMU upstream, we interrogate QEMU for the number of vcpus. For > others, we look directly into xenstore for information. > > Rep

[Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-08 Thread Wei Liu
... because the available vcpu bitmap can change during domain life time due to cpu hotplug and unplug. For QEMU upstream, we interrogate QEMU for the number of vcpus. For others, we look directly into xenstore for information. Reported-by: Jan Beulich Signed-off-by: Wei Liu --- tools/libxl/li