Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-20 Thread Wei Liu
On Mon, Jun 20, 2016 at 04:11:31AM -0600, Jan Beulich wrote: > >>> On 20.06.16 at 11:09, wrote: > > On Fri, Jun 17, 2016 at 08:45:39AM -0600, Jan Beulich wrote: > >> >>> On 17.06.16 at 15:50, wrote: > >> > On 17/06/16 12:05, Wei Liu wrote: > >> >> @@ -182,6 +183,28 @@ static int __init hvm_enable

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-20 Thread Jan Beulich
>>> On 20.06.16 at 11:09, wrote: > On Fri, Jun 17, 2016 at 08:45:39AM -0600, Jan Beulich wrote: >> >>> On 17.06.16 at 15:50, wrote: >> > On 17/06/16 12:05, Wei Liu wrote: >> >> @@ -182,6 +183,28 @@ static int __init hvm_enable(void) >> >> if ( !opt_altp2m_enabled ) >> >> hvm_funcs.a

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-20 Thread Wei Liu
On Fri, Jun 17, 2016 at 08:45:39AM -0600, Jan Beulich wrote: > >>> On 17.06.16 at 15:50, wrote: > > On 17/06/16 12:05, Wei Liu wrote: > >> @@ -182,6 +183,28 @@ static int __init hvm_enable(void) > >> if ( !opt_altp2m_enabled ) > >> hvm_funcs.altp2m_supported = 0; > >> > >> +if

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-17 Thread Wei Liu
On Fri, Jun 17, 2016 at 08:55:04AM -0600, Jan Beulich wrote: > >>> On 17.06.16 at 16:44, wrote: > > On Fri, Jun 17, 2016 at 08:40:40AM -0600, Jan Beulich wrote: > >> >>> On 17.06.16 at 16:32, wrote: > >> > On Fri, Jun 17, 2016 at 08:28:34AM -0600, Jan Beulich wrote: > >> >> >>> On 17.06.16 at 15:

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-17 Thread Jan Beulich
>>> On 17.06.16 at 16:44, wrote: > On Fri, Jun 17, 2016 at 08:40:40AM -0600, Jan Beulich wrote: >> >>> On 17.06.16 at 16:32, wrote: >> > On Fri, Jun 17, 2016 at 08:28:34AM -0600, Jan Beulich wrote: >> >> >>> On 17.06.16 at 15:51, wrote: >> >> > On 17/06/16 12:34, Jan Beulich wrote: >> >> > O

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-17 Thread Jan Beulich
>>> On 17.06.16 at 15:50, wrote: > On 17/06/16 12:05, Wei Liu wrote: >> @@ -182,6 +183,28 @@ static int __init hvm_enable(void) >> if ( !opt_altp2m_enabled ) >> hvm_funcs.altp2m_supported = 0; >> >> +if ( opt_hvm_fep ) >> +{ >> +unsigned int i, j; >> + >> +p

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-17 Thread Wei Liu
On Fri, Jun 17, 2016 at 08:40:40AM -0600, Jan Beulich wrote: > >>> On 17.06.16 at 16:32, wrote: > > On Fri, Jun 17, 2016 at 08:28:34AM -0600, Jan Beulich wrote: > >> >>> On 17.06.16 at 15:51, wrote: > >> > On 17/06/16 12:34, Jan Beulich wrote: > >> > On 17.06.16 at 13:05, wrote: > >> >>> ---

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-17 Thread Jan Beulich
>>> On 17.06.16 at 16:32, wrote: > On Fri, Jun 17, 2016 at 08:28:34AM -0600, Jan Beulich wrote: >> >>> On 17.06.16 at 15:51, wrote: >> > On 17/06/16 12:34, Jan Beulich wrote: >> > On 17.06.16 at 13:05, wrote: >> >>> --- a/xen/arch/x86/Kconfig >> >>> +++ b/xen/arch/x86/Kconfig >> >>> @@ -59,6

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-17 Thread Wei Liu
On Fri, Jun 17, 2016 at 08:28:34AM -0600, Jan Beulich wrote: > >>> On 17.06.16 at 15:51, wrote: > > On 17/06/16 12:34, Jan Beulich wrote: > > On 17.06.16 at 13:05, wrote: > >>> --- a/xen/arch/x86/Kconfig > >>> +++ b/xen/arch/x86/Kconfig > >>> @@ -59,6 +59,20 @@ config BIGMEM > >>> > >>>

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-17 Thread Jan Beulich
>>> On 17.06.16 at 15:51, wrote: > On 17/06/16 12:34, Jan Beulich wrote: > On 17.06.16 at 13:05, wrote: >>> --- a/xen/arch/x86/Kconfig >>> +++ b/xen/arch/x86/Kconfig >>> @@ -59,6 +59,20 @@ config BIGMEM >>> >>> If unsure, say N. >>> >>> +config HVM_FEP >>> + bool "HVM Forced Emula

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-17 Thread Andrew Cooper
On 17/06/16 12:34, Jan Beulich wrote: On 17.06.16 at 13:05, wrote: >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -59,6 +59,20 @@ config BIGMEM >> >>If unsure, say N. >> >> +config HVM_FEP >> +bool "HVM Forced Emulation Prefix support" > And no "if EXPERT"?

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-17 Thread Andrew Cooper
On 17/06/16 12:05, Wei Liu wrote: > Originally hvm_fep was guarded by NDEBUG, which means it was only > available to debug builds. > > However there is value to have it for non-debug builds as well. User can > use that to run tests in setup that replicates production setup. > > Make it clear with a

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-17 Thread Wei Liu
On Fri, Jun 17, 2016 at 05:34:07AM -0600, Jan Beulich wrote: > >>> On 17.06.16 at 13:05, wrote: > > --- a/xen/arch/x86/Kconfig > > +++ b/xen/arch/x86/Kconfig > > @@ -59,6 +59,20 @@ config BIGMEM > > > > If unsure, say N. > > > > +config HVM_FEP > > + bool "HVM Forced Emulation Prefix s

Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-17 Thread Jan Beulich
>>> On 17.06.16 at 13:05, wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -59,6 +59,20 @@ config BIGMEM > > If unsure, say N. > > +config HVM_FEP > + bool "HVM Forced Emulation Prefix support" And no "if EXPERT"? > @@ -95,9 +96,9 @@ unsigned long __section("

[Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

2016-06-17 Thread Wei Liu
Originally hvm_fep was guarded by NDEBUG, which means it was only available to debug builds. However there is value to have it for non-debug builds as well. User can use that to run tests in setup that replicates production setup. Make it clear with a sync_console style warning that this option c