Re: [Xen-devel] [PATCH v2 2/2] build/printf: fix incorrect format specifiers

2017-02-13 Thread Roger Pau Monne
On Mon, Feb 13, 2017 at 07:50:07AM -0700, Jan Beulich wrote: > >>> On 13.02.17 at 15:34, wrote: > > --- a/xen/arch/x86/cpu/mcheck/mce.c > > +++ b/xen/arch/x86/cpu/mcheck/mce.c > > @@ -595,9 +595,8 @@ int show_mca_info(int inited, struct cpuinfo_x86 *c) > > [mcheck_intel] = "Intel" > >

Re: [Xen-devel] [PATCH v2 2/2] build/printf: fix incorrect format specifiers

2017-02-13 Thread Jan Beulich
>>> On 13.02.17 at 15:34, wrote: > --- a/xen/arch/x86/cpu/mcheck/mce.c > +++ b/xen/arch/x86/cpu/mcheck/mce.c > @@ -595,9 +595,8 @@ int show_mca_info(int inited, struct cpuinfo_x86 *c) > [mcheck_intel] = "Intel" > }; > > -snprintf(prefix, ARRAY_SIZE(prefix), > -

Re: [Xen-devel] [PATCH v2 2/2] build/printf: fix incorrect format specifiers

2017-02-13 Thread Andrew Cooper
On 13/02/17 14:34, Roger Pau Monne wrote: > The following incorrect format specifiers and incorrect number of parameters > passed to printf like functions are reported by clang: > > mce.c:601:18: error: data argument not used by format string > [-Werror,-Wformat-extra-args] > smp_

[Xen-devel] [PATCH v2 2/2] build/printf: fix incorrect format specifiers

2017-02-13 Thread Roger Pau Monne
The following incorrect format specifiers and incorrect number of parameters passed to printf like functions are reported by clang: mce.c:601:18: error: data argument not used by format string [-Werror,-Wformat-extra-args] smp_processor_id()); ^ xenpm.c:102:23: