Re: [Xen-devel] [PATCH v2 1/7] build: add debug menu to Kconfig

2016-05-04 Thread Jan Beulich
>>> On 04.05.16 at 04:22, wrote: > On 5/3/16 10:18 AM, Jan Beulich wrote: > On 03.05.16 at 17:10, wrote: >>> On 03/05/16 16:05, Jan Beulich wrote: >>> On 03.05.16 at 16:29, wrote: > --- /dev/null > +++ b/xen/Kconfig.debug > @@ -0,0 +1,7 @@ > + > +menuconfig DEBUG

Re: [Xen-devel] [PATCH v2 1/7] build: add debug menu to Kconfig

2016-05-03 Thread Doug Goldstein
On 5/3/16 10:18 AM, Jan Beulich wrote: On 03.05.16 at 17:10, wrote: >> On 03/05/16 16:05, Jan Beulich wrote: >> On 03.05.16 at 16:29, wrote: --- /dev/null +++ b/xen/Kconfig.debug @@ -0,0 +1,7 @@ + +menuconfig DEBUG + bool "Debugging Options" >>> One more th

Re: [Xen-devel] [PATCH v2 1/7] build: add debug menu to Kconfig

2016-05-03 Thread Jan Beulich
>>> On 03.05.16 at 17:10, wrote: > On 03/05/16 16:05, Jan Beulich wrote: > On 03.05.16 at 16:29, wrote: >>> --- /dev/null >>> +++ b/xen/Kconfig.debug >>> @@ -0,0 +1,7 @@ >>> + >>> +menuconfig DEBUG >>> + bool "Debugging Options" >> One more thing: In the unstable branch this should really d

Re: [Xen-devel] [PATCH v2 1/7] build: add debug menu to Kconfig

2016-05-03 Thread Andrew Cooper
On 03/05/16 16:05, Jan Beulich wrote: On 03.05.16 at 16:29, wrote: >> --- /dev/null >> +++ b/xen/Kconfig.debug >> @@ -0,0 +1,7 @@ >> + >> +menuconfig DEBUG >> +bool "Debugging Options" > One more thing: In the unstable branch this should really default to > y, and the release check list s

Re: [Xen-devel] [PATCH v2 1/7] build: add debug menu to Kconfig

2016-05-03 Thread Jan Beulich
>>> On 03.05.16 at 16:29, wrote: > --- /dev/null > +++ b/xen/Kconfig.debug > @@ -0,0 +1,7 @@ > + > +menuconfig DEBUG > + bool "Debugging Options" One more thing: In the unstable branch this should really default to y, and the release check list should be adjusted to say that this default need

Re: [Xen-devel] [PATCH v2 1/7] build: add debug menu to Kconfig

2016-05-03 Thread Doug Goldstein
On 5/3/16 9:38 AM, Jan Beulich wrote: On 03.05.16 at 16:29, wrote: >> --- a/xen/include/xen/config.h >> +++ b/xen/include/xen/config.h >> @@ -81,4 +81,8 @@ >> /* allow existing code to work with Kconfig variable */ >> #define NR_CPUS CONFIG_NR_CPUS >> >> +#ifndef CONFIG_DEBUG >> +#define

Re: [Xen-devel] [PATCH v2 1/7] build: add debug menu to Kconfig

2016-05-03 Thread Jan Beulich
>>> On 03.05.16 at 16:29, wrote: > --- a/xen/include/xen/config.h > +++ b/xen/include/xen/config.h > @@ -81,4 +81,8 @@ > /* allow existing code to work with Kconfig variable */ > #define NR_CPUS CONFIG_NR_CPUS > > +#ifndef CONFIG_DEBUG > +#define NDEBUG > +#endif At the same time you should d

[Xen-devel] [PATCH v2 1/7] build: add debug menu to Kconfig

2016-05-03 Thread Doug Goldstein
There are a number of debugging options for Xen so the idea is to have a menu to group them all together. Enabling this menu item will also disable NDEBUG which will result in more debug prints. This was previously wired into the 'debug=y' command line option. Signed-off-by: Doug Goldstein --- CC