Re: [Xen-devel] [PATCH v2 1/5] xen/console: consolidate log levels to an array

2016-07-07 Thread Jan Beulich
>>> On 04.07.16 at 17:13, wrote: > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -139,6 +139,20 @@ custom_param("guest_loglvl", parse_guest_loglvl); > > static atomic_t print_everything = ATOMIC_INIT(0); > > +struct log_level { > +const char *str; > +unsigne

Re: [Xen-devel] [PATCH v2 1/5] xen/console: consolidate log levels to an array

2016-07-04 Thread Wei Liu
On Mon, Jul 04, 2016 at 04:13:22PM +0100, Wei Liu wrote: > It cleaner than open-coding strings and numbers. The array will also > become handy later when we need to refactor things a bit. > > No functional change. > > Signed-off-by: Wei Liu > --- > Cc: Jan Beulich > --- > xen/drivers/char/cons

[Xen-devel] [PATCH v2 1/5] xen/console: consolidate log levels to an array

2016-07-04 Thread Wei Liu
It cleaner than open-coding strings and numbers. The array will also become handy later when we need to refactor things a bit. No functional change. Signed-off-by: Wei Liu --- Cc: Jan Beulich --- xen/drivers/char/console.c | 25 +++-- 1 file changed, 19 insertions(+), 6 del