Re: [Xen-devel] [PATCH v2 1/5] libxc: remove allocate member from struct xc_dom_image

2015-10-02 Thread Juergen Gross
On 10/02/2015 04:47 PM, Ian Campbell wrote: On Fri, 2015-10-02 at 16:25 +0200, Juergen Gross wrote: On 10/02/2015 03:01 PM, Ian Campbell wrote: On Fri, 2015-10-02 at 07:49 +0200, Juergen Gross wrote: The allocate() callback in struct xc_dom_image is never set. Remove it. Signed-off-by: Juerge

Re: [Xen-devel] [PATCH v2 1/5] libxc: remove allocate member from struct xc_dom_image

2015-10-02 Thread Ian Campbell
On Fri, 2015-10-02 at 16:25 +0200, Juergen Gross wrote: > On 10/02/2015 03:01 PM, Ian Campbell wrote: > > On Fri, 2015-10-02 at 07:49 +0200, Juergen Gross wrote: > > > The allocate() callback in struct xc_dom_image is never set. Remove > > > it. > > > > > > Signed-off-by: Juergen Gross > > > Acke

Re: [Xen-devel] [PATCH v2 1/5] libxc: remove allocate member from struct xc_dom_image

2015-10-02 Thread Juergen Gross
On 10/02/2015 03:01 PM, Ian Campbell wrote: On Fri, 2015-10-02 at 07:49 +0200, Juergen Gross wrote: The allocate() callback in struct xc_dom_image is never set. Remove it. Signed-off-by: Juergen Gross Acked-by: Ian Jackson This breaks the stubdom build: kexec.c: In function ‘kexec’: kexec.

Re: [Xen-devel] [PATCH v2 1/5] libxc: remove allocate member from struct xc_dom_image

2015-10-02 Thread Ian Campbell
On Fri, 2015-10-02 at 07:49 +0200, Juergen Gross wrote: > The allocate() callback in struct xc_dom_image is never set. Remove it. > > Signed-off-by: Juergen Gross > Acked-by: Ian Jackson This breaks the stubdom build: kexec.c: In function ‘kexec’: kexec.c:221:78: warning: taking address of exp

[Xen-devel] [PATCH v2 1/5] libxc: remove allocate member from struct xc_dom_image

2015-10-01 Thread Juergen Gross
The allocate() callback in struct xc_dom_image is never set. Remove it. Signed-off-by: Juergen Gross Acked-by: Ian Jackson --- tools/libxc/include/xc_dom.h | 2 -- tools/libxc/xc_dom_core.c| 4 2 files changed, 6 deletions(-) diff --git a/tools/libxc/include/xc_dom.h b/tools/libxc/inc