Re: [Xen-devel] [PATCH v2 1/4] libxc/libxl: fill xc_hvm_build_args in libxl

2015-05-29 Thread Wei Liu
On Fri, May 29, 2015 at 01:29:18PM +0100, Andrew Cooper wrote: > On 29/05/15 12:37, Wei Liu wrote: > > When building HVM guests, originally some fields of xc_hvm_build_args > > are filled in xc_hvm_build (and buried in the wrong function), some are > > set in libxl__build_hvm before passing xc_hvm_

Re: [Xen-devel] [PATCH v2 1/4] libxc/libxl: fill xc_hvm_build_args in libxl

2015-05-29 Thread Andrew Cooper
On 29/05/15 12:37, Wei Liu wrote: > When building HVM guests, originally some fields of xc_hvm_build_args > are filled in xc_hvm_build (and buried in the wrong function), some are > set in libxl__build_hvm before passing xc_hvm_build_args to > xc_hvm_build. This is fragile. > > After examining the

[Xen-devel] [PATCH v2 1/4] libxc/libxl: fill xc_hvm_build_args in libxl

2015-05-29 Thread Wei Liu
When building HVM guests, originally some fields of xc_hvm_build_args are filled in xc_hvm_build (and buried in the wrong function), some are set in libxl__build_hvm before passing xc_hvm_build_args to xc_hvm_build. This is fragile. After examining the code in xc_hvm_build that sets those fields,