Re: [Xen-devel] [PATCH v2 1/3] xen: RCU: let the RCU idle timer handler run

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 16:08, wrote: > If the problem is "just" the parameter (or maybe both the parameter's > and the function's) name(s), I 'd be happy to change the parameter name > to 't', or 'time' (and the function to 'timer_expires_before()'), and > this is my preference. > > But if you strong

Re: [Xen-devel] [PATCH v2 1/3] xen: RCU: let the RCU idle timer handler run

2017-09-28 Thread Dario Faggioli
On Thu, 2017-09-28 at 06:59 -0600, Jan Beulich wrote: > > > > On 28.09.17 at 12:15, wrote: > > --- a/xen/common/rcupdate.c > > +++ b/xen/common/rcupdate.c > > @@ -465,7 +465,21 @@ void rcu_idle_timer_stop() > >  return; > >   > >  rdp->idle_timer_active = false; > > -stop_timer(&rd

Re: [Xen-devel] [PATCH v2 1/3] xen: RCU: let the RCU idle timer handler run

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 12:15, wrote: > --- a/xen/common/rcupdate.c > +++ b/xen/common/rcupdate.c > @@ -465,7 +465,21 @@ void rcu_idle_timer_stop() > return; > > rdp->idle_timer_active = false; > -stop_timer(&rdp->idle_timer); > + > +/* > + * In general, as the CPU is becomi

[Xen-devel] [PATCH v2 1/3] xen: RCU: let the RCU idle timer handler run

2017-09-28 Thread Dario Faggioli
If stop_timer() is called between when the RCU idle timer's interrupt arrives (and TIMER_SOFTIRQ is raised) and when softirqs are checked and handled, the timer is deactivated, and the handler never runs. This happens to the RCU idle timer because stop_timer() is called on it during the wakeup fro