Re: [Xen-devel] [PATCH v2 1/3] x86/vlapic: Introduce vlapic_update_timer

2017-08-04 Thread Anthony PERARD
On Fri, Aug 04, 2017 at 09:40:32AM -0600, Jan Beulich wrote: > >>> Anthony PERARD 08/04/17 12:52 PM >>> > >On Thu, Aug 03, 2017 at 08:59:10AM -0600, Jan Beulich wrote: > >> >>> Anthony PERARD 07/18/17 7:10 PM >>> > >> >+static void vlapic_update_timer(struct vlapic *vlapic, uint32_t lvtt); > >> >

Re: [Xen-devel] [PATCH v2 1/3] x86/vlapic: Introduce vlapic_update_timer

2017-08-04 Thread Jan Beulich
>>> Anthony PERARD 08/04/17 12:52 PM >>> >On Thu, Aug 03, 2017 at 08:59:10AM -0600, Jan Beulich wrote: >> >>> Anthony PERARD 07/18/17 7:10 PM >>> >> >+static void vlapic_update_timer(struct vlapic *vlapic, uint32_t lvtt); >> >+{ >> >+uint64_t period; >> >+uint64_t delta; >> >> Why two li

Re: [Xen-devel] [PATCH v2 1/3] x86/vlapic: Introduce vlapic_update_timer

2017-08-04 Thread Anthony PERARD
On Thu, Aug 03, 2017 at 08:59:10AM -0600, Jan Beulich wrote: > >>> Anthony PERARD 07/18/17 7:10 PM >>> > >There should not be any functionality change with this patch. > > > >This function is used when the APIC_TMICT register is updated. > > > >vlapic_update_timer is introduce as it will be use al

Re: [Xen-devel] [PATCH v2 1/3] x86/vlapic: Introduce vlapic_update_timer

2017-08-03 Thread Jan Beulich
>>> Anthony PERARD 07/18/17 7:10 PM >>> >There should not be any functionality change with this patch. > >This function is used when the APIC_TMICT register is updated. > >vlapic_update_timer is introduce as it will be use also when the >registers APIC_LVTT and APIC_TDCR are updated. > >Signed-off

[Xen-devel] [PATCH v2 1/3] x86/vlapic: Introduce vlapic_update_timer

2017-07-18 Thread Anthony PERARD
There should not be any functionality change with this patch. This function is used when the APIC_TMICT register is updated. vlapic_update_timer is introduce as it will be use also when the registers APIC_LVTT and APIC_TDCR are updated. Signed-off-by: Anthony PERARD --- xen/arch/x86/hvm/vlapic