Re: [Xen-devel] [PATCH v2 09/23] acpi/hvmloader: Build WAET optionally

2016-08-09 Thread Jan Beulich
>>> On 09.08.16 at 17:13, wrote: > On 08/09/2016 10:48 AM, Jan Beulich wrote: > On 09.08.16 at 15:51, wrote: >>> On 08/09/2016 09:29 AM, Jan Beulich wrote: >>> On 04.08.16 at 23:06, wrote: > Signed-off-by: Boris Ostrovsky > Reviewed-by: Jan Beulich > --- > v2: > * N

Re: [Xen-devel] [PATCH v2 09/23] acpi/hvmloader: Build WAET optionally

2016-08-09 Thread Boris Ostrovsky
On 08/09/2016 10:48 AM, Jan Beulich wrote: On 09.08.16 at 15:51, wrote: >> On 08/09/2016 09:29 AM, Jan Beulich wrote: >> On 04.08.16 at 23:06, wrote: Signed-off-by: Boris Ostrovsky Reviewed-by: Jan Beulich --- v2: * Note: didn't break "if ( !waet ) return -1" l

Re: [Xen-devel] [PATCH v2 09/23] acpi/hvmloader: Build WAET optionally

2016-08-09 Thread Jan Beulich
>>> On 09.08.16 at 15:51, wrote: > On 08/09/2016 09:29 AM, Jan Beulich wrote: > On 04.08.16 at 23:06, wrote: >>> Signed-off-by: Boris Ostrovsky >>> Reviewed-by: Jan Beulich >>> --- >>> v2: >>> * Note: didn't break "if ( !waet ) return -1" line since that's the style >>> of the file. >> St

Re: [Xen-devel] [PATCH v2 09/23] acpi/hvmloader: Build WAET optionally

2016-08-09 Thread Boris Ostrovsky
On 08/09/2016 09:29 AM, Jan Beulich wrote: On 04.08.16 at 23:06, wrote: >> Signed-off-by: Boris Ostrovsky >> Reviewed-by: Jan Beulich >> --- >> v2: >> * Note: didn't break "if ( !waet ) return -1" line since that's the style >> of the file. > Style of the file? At best there's a mix in th

Re: [Xen-devel] [PATCH v2 09/23] acpi/hvmloader: Build WAET optionally

2016-08-09 Thread Jan Beulich
>>> On 04.08.16 at 23:06, wrote: > Signed-off-by: Boris Ostrovsky > Reviewed-by: Jan Beulich > --- > v2: > * Note: didn't break "if ( !waet ) return -1" line since that's the style > of the file. Style of the file? At best there's a mix in the file, and hence correcting it here is rather desi

[Xen-devel] [PATCH v2 09/23] acpi/hvmloader: Build WAET optionally

2016-08-04 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky Reviewed-by: Jan Beulich --- v2: * Note: didn't break "if ( !waet ) return -1" line since that's the style of the file. tools/firmware/hvmloader/acpi/build.c | 9 ++--- tools/firmware/hvmloader/acpi/libacpi.h | 1 + tools/firmware/hvmloader/util.c