Re: [Xen-devel] [PATCH v2 08/29] ArmVirtualizationPkg: add padding to FDT allocation

2015-01-30 Thread Laszlo Ersek
On 01/28/15 17:18, Ard Biesheuvel wrote: > On 28 January 2015 at 15:13, Olivier Martin wrote: >> Same question as last time, would it not be better to have a PCD instead of >> hardcoded value? > > Ah yes, I remember reading that but failed to take it into account. > >> Some platforms might want

Re: [Xen-devel] [PATCH v2 08/29] ArmVirtualizationPkg: add padding to FDT allocation

2015-01-28 Thread Ard Biesheuvel
On 28 January 2015 at 15:13, Olivier Martin wrote: > Same question as last time, would it not be better to have a PCD instead of > hardcoded value? Ah yes, I remember reading that but failed to take it into account. > Some platforms might want to have a larger FDT padding. > Agreed. Will add it

Re: [Xen-devel] [PATCH v2 08/29] ArmVirtualizationPkg: add padding to FDT allocation

2015-01-28 Thread Olivier Martin
Same question as last time, would it not be better to have a PCD instead of hardcoded value? Some platforms might want to have a larger FDT padding. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 26 January 2015 19:03 > To: edk2-de...@lists.sourcefo

[Xen-devel] [PATCH v2 08/29] ArmVirtualizationPkg: add padding to FDT allocation

2015-01-26 Thread Ard Biesheuvel
Our primary user QEMU/mach-virt presents us with a FDT blob padded to 64 KB with plenty of room to set additional properties. However, in the general case, we should only add properties after making sure there is enough room available. Contributed-under: TianoCore Contribution Agreement 1.0 Signed