Re: [Xen-devel] [PATCH v2 05/13] xen/pvcalls: implement bind command

2017-07-31 Thread Stefano Stabellini
On Thu, 27 Jul 2017, Boris Ostrovsky wrote: > >> This all looks very similar to previous patches. Can it be factored out? > > You are right that the pattern is the same for all commands: > > - get a request > > - fill the request > > - possibly do something else > > - wait > > however each request

Re: [Xen-devel] [PATCH v2 05/13] xen/pvcalls: implement bind command

2017-07-27 Thread Boris Ostrovsky
>> This all looks very similar to previous patches. Can it be factored out? > You are right that the pattern is the same for all commands: > - get a request > - fill the request > - possibly do something else > - wait > however each request is different, the struct and fields are different. > Ther

Re: [Xen-devel] [PATCH v2 05/13] xen/pvcalls: implement bind command

2017-07-26 Thread Stefano Stabellini
On Wed, 26 Jul 2017, Boris Ostrovsky wrote: > On 7/25/2017 5:22 PM, Stefano Stabellini wrote: > > Send PVCALLS_BIND to the backend. Introduce a new structure, part of > > struct sock_mapping, to store information specific to passive sockets. > > > > Introduce a status field to keep track of the st

Re: [Xen-devel] [PATCH v2 05/13] xen/pvcalls: implement bind command

2017-07-26 Thread Boris Ostrovsky
On 7/25/2017 5:22 PM, Stefano Stabellini wrote: Send PVCALLS_BIND to the backend. Introduce a new structure, part of struct sock_mapping, to store information specific to passive sockets. Introduce a status field to keep track of the status of the passive socket. Introduce a waitqueue for the

[Xen-devel] [PATCH v2 05/13] xen/pvcalls: implement bind command

2017-07-25 Thread Stefano Stabellini
Send PVCALLS_BIND to the backend. Introduce a new structure, part of struct sock_mapping, to store information specific to passive sockets. Introduce a status field to keep track of the status of the passive socket. Introduce a waitqueue for the "accept" command (see the accept command implementa