Re: [Xen-devel] [PATCH v2 04/17] libxl/arm: prepare for constructing ACPI tables

2016-06-23 Thread Julien Grall
Hi Shannon, On 23/06/16 04:16, Shannon Zhao wrote: [...] diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index cc5a717..f5db74b 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@ -1,6 +1,7 @@ #include "libxl_internal.h" #include "libxl_arch.h" #include "

Re: [Xen-devel] [PATCH v2 04/17] libxl/arm: prepare for constructing ACPI tables

2016-06-23 Thread Stefano Stabellini
On Thu, 23 Jun 2016, Shannon Zhao wrote: > On 2016年06月23日 21:37, Stefano Stabellini wrote: > > On Thu, 23 Jun 2016, Shannon Zhao wrote: > >> + > >> +if (strcmp(dom->guest_type, "xen-3.0-aarch64")) { > >> +LOG(DEBUG, "Do not generate ACPI tables for %s", dom->guest_type); > >> +s

Re: [Xen-devel] [PATCH v2 04/17] libxl/arm: prepare for constructing ACPI tables

2016-06-23 Thread Shannon Zhao
On 2016年06月23日 21:37, Stefano Stabellini wrote: > On Thu, 23 Jun 2016, Shannon Zhao wrote: >> + >> +if (strcmp(dom->guest_type, "xen-3.0-aarch64")) { >> +LOG(DEBUG, "Do not generate ACPI tables for %s", dom->guest_type); >> +state->config.acpi = false; > > Shouldn't we return h

Re: [Xen-devel] [PATCH v2 04/17] libxl/arm: prepare for constructing ACPI tables

2016-06-23 Thread Stefano Stabellini
On Thu, 23 Jun 2016, Shannon Zhao wrote: > From: Shannon Zhao > > It only constructs the ACPI tables for 64-bit ARM DomU when user enables > acpi because 32-bit DomU doesn't support ACPI. > > Signed-off-by: Shannon Zhao > --- > tools/libxl/Makefile | 4 +++ > tools/libxl/libxl_arm.c

[Xen-devel] [PATCH v2 04/17] libxl/arm: prepare for constructing ACPI tables

2016-06-22 Thread Shannon Zhao
From: Shannon Zhao It only constructs the ACPI tables for 64-bit ARM DomU when user enables acpi because 32-bit DomU doesn't support ACPI. Signed-off-by: Shannon Zhao --- tools/libxl/Makefile | 4 +++ tools/libxl/libxl_arm.c | 19 +- tools/libxl/libxl_arm_acpi.c | 85